Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1690183003: Store enums in summary file as bytes. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store enums in summary file as bytes. Reduces SDK summary file size by about 1%. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/92ad0e0cbacd7a7d9332d03f0e7d1bb2a44bf125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -56 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 15 chunks +79 lines, -35 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 12 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-12 13:16:05 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-12 14:54:34 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-12 18:57:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92ad0e0cbacd7a7d9332d03f0e7d1bb2a44bf125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698