content: Increase thread priority for display critical IO threads on ChromeOS.

content: Increase thread priority for display critical IO threads on ChromeOS.

Up the priority of the browser and GPU process IO threads as some of its
IPCs relate to display tasks. This is consistent with Android except in
the case of ChromeOS we avoid increasing the priority of all IO threads.

BUG=internal b/26877099

Committed: https://crrev.com/7caf8cf65104cec17815f389884da6a156fd2a0e
Cr-Commit-Position: refs/heads/master@{#375506}

[reveman, 2016-02-12 20:50:44]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[reveman, 2016-02-12 20:50:52]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[commit-bot: I haz the power, 2016-02-12 20:51:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690173004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690173004/1

[piman, 2016-02-12 21:09:14]

lgtm

https://codereview.chromium.org/1690173004/diff/1/content/gpu/in_process_gpu_...
File content/gpu/in_process_gpu_thread.cc (right):

https://codereview.chromium.org/1690173004/diff/1/content/gpu/in_process_gpu_...
content/gpu/in_process_gpu_thread.cc:50: gpu_process_ = new
GpuProcess(base::ThreadPriority::NORMAL);
Android uses this, and it would make sense to bump to DISPLAY too. If I follow
the code correctly, it is done in ChildProcess, but it could make sense to do it
explicitly here (and maybe eventually remove from ChildProcess, since it may not
make sense for e.g. the utility process, and arguable on the renderer).

[reveman, 2016-02-12 21:40:21]

The CQ bit was checked by reveman@chromium.org

[reveman, 2016-02-12 21:40:22]

https://codereview.chromium.org/1690173004/diff/1/content/gpu/in_process_gpu_...
File content/gpu/in_process_gpu_thread.cc (right):

https://codereview.chromium.org/1690173004/diff/1/content/gpu/in_process_gpu_...
content/gpu/in_process_gpu_thread.cc:50: gpu_process_ = new
GpuProcess(base::ThreadPriority::NORMAL);
On 2016/02/12 at 21:09:14, piman wrote:
> Android uses this, and it would make sense to bump to DISPLAY too. If I follow
the code correctly, it is done in ChildProcess, but it could make sense to do it
explicitly here (and maybe eventually remove from ChildProcess, since it may not
make sense for e.g. the utility process, and arguable on the renderer).

Makes sense. Latest patch sets the priority here and I added a TODO for removing
it from ChildProcess ctor. I'd rather not change the priority of any threads on
Android as part of this patch.

FYI, we increase the priority of the compositor thread in the renderer on
Android. Not sure that's a good idea but it makes sense to also increase the
priority of the IO thread when we do that.

[reveman, 2016-02-12 21:40:22]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1690173004/#ps20001
(title: "Explicitly set io thread priority in InProcessGpuThread::Init for
Android")

[commit-bot: I haz the power, 2016-02-12 21:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690173004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690173004/20001

[commit-bot: I haz the power, 2016-02-12 21:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 21:48:12]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[reveman, 2016-02-12 21:49:53]

The CQ bit was checked by reveman@chromium.org

[reveman, 2016-02-12 21:49:54]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1690173004/#ps40001
(title: "cl format")

[commit-bot: I haz the power, 2016-02-12 21:50:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690173004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690173004/40001

[commit-bot: I haz the power, 2016-02-12 21:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 21:56:41]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[reveman, 2016-02-16 01:30:09]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-02-16 01:30:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690173004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690173004/40001

[commit-bot: I haz the power, 2016-02-16 02:39:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-16 22:51:10]

Description was changed from

==========
content: Increase thread priority for display critical IO threads on ChromeOS.

Up the priority of the browser and GPU process IO threads as some of its
IPCs relate to display tasks. This is consistent with Android except in
the case of ChromeOS we avoid increasing the priority of all IO threads.

BUG=internal b/26877099
==========

to

==========
content: Increase thread priority for display critical IO threads on ChromeOS.

Up the priority of the browser and GPU process IO threads as some of its
IPCs relate to display tasks. This is consistent with Android except in
the case of ChromeOS we avoid increasing the priority of all IO threads.

BUG=internal b/26877099

Committed: https://crrev.com/7caf8cf65104cec17815f389884da6a156fd2a0e
Cr-Commit-Position: refs/heads/master@{#375506}
==========

[commit-bot: I haz the power, 2016-02-16 22:51:11]

Patchset 3 (id:??) landed as
https://crrev.com/7caf8cf65104cec17815f389884da6a156fd2a0e
Cr-Commit-Position: refs/heads/master@{#375506}