src/runtime/runtime-debug.cc - Issue 1690173002: Ignore pause on debugger statement when breakpoints are disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 1690173002: Ignore pause on debugger statement when breakpoints are disabled (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Move check to Runtime_HandleDebuggerStatement Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 2be6c97493e2269078baacbc032671a736c3241f..f4942ccd18bdba2a15a28dae112da82797d2e9bd 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -30,7 +30,8 @@ RUNTIME_FUNCTION(Runtime_DebugBreak) {

RUNTIME_FUNCTION(Runtime_HandleDebuggerStatement) {

SealHandleScope shs(isolate);

DCHECK(args.length() == 0);

- isolate->debug()->HandleDebugBreak();

+ if (isolate->debug()->break_points_active())

Yang 2016/02/12 20:17:41 Please add curly brackets.

kozy 2016/02/12 20:29:07 Done.

+ isolate->debug()->HandleDebugBreak();

return isolate->heap()->undefined_value();

}

« no previous file with comments | « src/debug/debug.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »