Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 169014: Remove URLRequest::Restart() because it is only referenced by unit tests (Closed)

Created:
11 years, 4 months ago by Marshall Greenblatt
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove URLRequest::Restart() because it is only referenced by unit tests. BUG=17556 TEST=existing net_unittests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -115 lines) Patch
M net/url_request/url_request.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/url_request/url_request.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_job.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 7 chunks +2 lines, -95 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Marshall Greenblatt
Please review.
11 years, 4 months ago (2009-08-14 21:17:55 UTC) #1
michaeln
Please don't delete this functionality, I have a use case that depends it on being ...
11 years, 3 months ago (2009-09-11 20:14:51 UTC) #2
michaeln
11 years, 1 month ago (2009-11-05 04:53:42 UTC) #3
On 2009/09/11 20:14:51, michaeln wrote:
> Please don't delete this functionality, I have a use case that depends it on
> being there.

Here is that use case...
http://codereview.chromium.org/338034/diff/24049/23040

Powered by Google App Engine
This is Rietveld 408576698