ui/views/window/client_view.cc - Issue 1690133003: DialogClientView: Correct the order in which subviews are focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/window/client_view.cc

Issue 1690133003: DialogClientView: Correct the order in which subviews are focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/window/client_view.cc

diff --git a/ui/views/window/client_view.cc b/ui/views/window/client_view.cc

index fb7d89fed1823b670feb600d00685f1e83f4526a..ed690b407002aee6cdcb677efe8381bd02ddfb6f 100644

--- a/ui/views/window/client_view.cc

+++ b/ui/views/window/client_view.cc

@@ -92,7 +92,8 @@ void ClientView::ViewHierarchyChanged(

// Insert |contents_view_| at index 0 so it is first in the focus chain.

// (the OK/Cancel buttons are inserted before contents_view_)

AddChildViewAt(contents_view_, 0);

- }

+ } else if (!details.is_add && details.child == contents_view_)

sky 2016/02/22 16:38:57 nit {} (because this an else block of a conditiona

karandeepb 2016/02/22 23:40:37 Done.

+ contents_view_ = nullptr;

}

} // namespace views

« no previous file with comments | « no previous file | ui/views/window/dialog_client_view.h » ('j') | no next file with comments »