device/bluetooth/bluetooth_device_win.cc - Issue 1690133002: Implement BluetoothRemoteGattServiceWin and related unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_device_win.cc

Issue 1690133002: Implement BluetoothRemoteGattServiceWin and related unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments and split out of included GATT services Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_adapter_win.cc ('k') | device/bluetooth/bluetooth_gatt_service_unittest.cc » ('j') | device/bluetooth/bluetooth_remote_gatt_service_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_device_win.cc

diff --git a/device/bluetooth/bluetooth_device_win.cc b/device/bluetooth/bluetooth_device_win.cc

index d63b9d0434863ac671596c8e8ab87d7dd7694967..514a1000fb4459c248e4c12fd0b658452c569088 100644

--- a/device/bluetooth/bluetooth_device_win.cc

+++ b/device/bluetooth/bluetooth_device_win.cc

@@ -350,7 +350,7 @@ void BluetoothDeviceWin::UpdateGattServices(

}

for (const auto& service : to_be_removed_services) {

- gatt_services_.erase(service);

+ gatt_services_.take_and_erase(service);

}

// Update previously discovered services.

for (auto gatt_service : gatt_services_) {