Issue 169013002: bookmarks: Rename bookmark_context_menu_test.cc to bookmark_context_menu_unittest.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169013002: bookmarks: Rename bookmark_context_menu_test.cc to bookmark_context_menu_unittest.cc (Closed)

Created:
6 years, 10 months ago by tfarina

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

bookmarks: Rename bookmark_context_menu_test.cc to bookmark_context_menu_unittest.cc We use unittest.cc suffix for tests that use gtest and are not interactive ui tests or browser tests. This is also more consistent with the files around. BUG=180681 TEST=unit_tests R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252096

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -331 lines)			Patch
D	chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc	View	1 chunk	+0 lines, -331 lines	0 comments	Download
A +	chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/169013002/1

6 years, 10 months ago (2014-02-19 16:23:07 UTC) #4

Message was sent while issue was closed.

Change committed as 252096

Expand Messages | Collapse Messages