net/cert/internal/signature_algorithm_unittest.cc - Issue 1690123002: Reduce Certificate Parsing Strictness

Unified Diff: net/cert/internal/signature_algorithm_unittest.cc

Issue 1690123002: Reduce Certificate Parsing Strictness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing tests. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/internal/signature_algorithm_unittest.cc

diff --git a/net/cert/internal/signature_algorithm_unittest.cc b/net/cert/internal/signature_algorithm_unittest.cc

index 0336c57925526906e6e98da26a93bf61810fc195..678ef5a9d93950cd7cbc8296b2ecc3745681c979 100644

--- a/net/cert/internal/signature_algorithm_unittest.cc

+++ b/net/cert/internal/signature_algorithm_unittest.cc

@@ -72,7 +72,7 @@ TEST(SignatureAlgorithmTest, ParseDerSha1WithRSAEncryptionNoParams) {

};

// clang-format on

scoped_ptr<SignatureAlgorithm> algorithm;

- ASSERT_FALSE(ParseDer(kData, &algorithm));

+ ASSERT_TRUE(ParseDer(kData, &algorithm));

eroman 2016/02/12 21:09:44 Check the values of |algorithm| now that this expe

svaldez 2016/02/12 22:00:11 Done.

}

// Parses a sha1WithRSAEncryption which contains an unexpected parameters

@@ -128,7 +128,7 @@ TEST(SignatureAlgorithmTest, ParseDerSha1WithRSASignatureNoParams) {

};

// clang-format on

scoped_ptr<SignatureAlgorithm> algorithm;

- ASSERT_FALSE(ParseDer(kData, &algorithm));

+ ASSERT_TRUE(ParseDer(kData, &algorithm));

eroman 2016/02/12 21:09:44 Same here.

svaldez 2016/02/12 22:00:11 Done.

}

// Parses a sha1WithRSAEncryption which contains values after the sequence.

@@ -240,7 +240,7 @@ TEST(SignatureAlgorithmTest, ParseDerSha256WithRSAEncryptionNoParams) {

};

// clang-format on

scoped_ptr<SignatureAlgorithm> algorithm;

- ASSERT_FALSE(ParseDer(kData, &algorithm));

+ ASSERT_TRUE(ParseDer(kData, &algorithm));

eroman 2016/02/12 21:09:44 Same here.

svaldez 2016/02/12 22:00:11 Done.

}

// Parses a sha384WithRSAEncryption which contains a NULL parameters field.

@@ -277,7 +277,7 @@ TEST(SignatureAlgorithmTest, ParseDerSha384WithRSAEncryptionNoParams) {

};

// clang-format on

scoped_ptr<SignatureAlgorithm> algorithm;

- ASSERT_FALSE(ParseDer(kData, &algorithm));

+ ASSERT_TRUE(ParseDer(kData, &algorithm));

eroman 2016/02/12 21:09:44 And here.

svaldez 2016/02/12 22:00:11 Done.

}

// Parses a sha512WithRSAEncryption which contains a NULL parameters field.

@@ -314,7 +314,7 @@ TEST(SignatureAlgorithmTest, ParseDerSha512WithRSAEncryptionNoParams) {

};

// clang-format on

scoped_ptr<SignatureAlgorithm> algorithm;

- ASSERT_FALSE(ParseDer(kData, &algorithm));

+ ASSERT_TRUE(ParseDer(kData, &algorithm));

eroman 2016/02/12 21:09:44 ...

svaldez 2016/02/12 22:00:11 Done.

}

// Parses a sha224WithRSAEncryption which contains a NULL parameters field.

« net/cert/internal/signature_algorithm.cc ('K') | « net/cert/internal/signature_algorithm.cc ('k') | no next file » | no next file with comments »