Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/cert/internal/parse_certificate_unittest.cc

Issue 1690123002: Reduce Certificate Parsing Strictness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing unittest. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/internal/parse_certificate.cc ('K') | « net/cert/internal/parse_certificate.cc ('k') | net/cert/internal/signature_algorithm.cc » ('j') | net/cert/internal/signature_algorithm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_certificate_unittest.cc
diff --git a/net/cert/internal/parse_certificate_unittest.cc b/net/cert/internal/parse_certificate_unittest.cc
index eea4d4024be7ab5f49975cb9d91645640511ba89..c62651b6e88c9ef7eabfff0ccca20aed24a4e9ad 100644
--- a/net/cert/internal/parse_certificate_unittest.cc
+++ b/net/cert/internal/parse_certificate_unittest.cc
@@ -220,7 +220,8 @@ TEST(ParseTbsCertificateTest, NegativeSerialNumber) {
// Tests parsing a TBSCertificate with a serial number that is 21 octets long
// (and the first byte is 0).
TEST(ParseTbCertificateTest, SerialNumber21OctetsLeading0) {
- EnsureParsingTbsFails("tbs_serial_number_21_octets_leading_0.pem");
+ EnsureParsingTbsSucceeds("tbs_serial_number_21_octets_leading_0.pem",
+ CertificateVersion::V3);
}
// Tests parsing a TBSCertificate with a serial number that is 26 octets long
« net/cert/internal/parse_certificate.cc ('K') | « net/cert/internal/parse_certificate.cc ('k') | net/cert/internal/signature_algorithm.cc » ('j') | net/cert/internal/signature_algorithm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698