ui/base/ime/input_method_tsf.cc - Issue 16901011: Support CancelCompositionText/ComfirmCompositionText in TSF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_tsf.cc

Issue 16901011: Support CancelCompositionText/ComfirmCompositionText in TSF (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/input_method_tsf.cc

diff --git a/ui/base/ime/input_method_tsf.cc b/ui/base/ime/input_method_tsf.cc

index 6c433d6e0961247fb3546ed95fcb4bb1d3f8c4dd..fa3715731d88543c88fe7805c284906a91df7715 100644

--- a/ui/base/ime/input_method_tsf.cc

+++ b/ui/base/ime/input_method_tsf.cc

@@ -119,10 +119,7 @@ void InputMethodTSF::OnDidChangeFocusedClient(TextInputClient* focused_before,

void InputMethodTSF::ConfirmCompositionText() {

if (!IsTextInputTypeNone()) {

- // TSFBridge has not implemented ConfirmComposition yet. So here cancel

- // the composition instead as a workaround.

- // TODO(ime): Implement ConfirmComposition for TSF.

- ui::TSFBridge::GetInstance()->CancelComposition();

+ ui::TSFBridge::GetInstance()->ConfirmComposition();

}

« no previous file with comments | « no previous file | ui/base/ime/win/mock_tsf_bridge.h » ('j') | ui/base/ime/win/tsf_bridge.cc » ('J')