Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 16901011: Support CancelCompositionText/ComfirmCompositionText in TSF (Closed)

Created:
7 years, 6 months ago by Yohei Yukawa
Modified:
7 years, 6 months ago
Reviewers:
yukawa, Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, kochi, Yuki, yoichio
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Support CancelCompositionText/ComfirmCompositionText in TSF. Currently CancelCompositionText is not fully implemented in InputMethodTSF. This CL fixes the issue. Note: CUAS is also implementing the protocol conversions from ImmNotifyIME(NI_COMPOSITIONSTR, CPS_CANCEL, 0) and ImmNotifyIME(NI_COMPOSITIONSTR, CPS_COMPLETE, 0) into TSF operations, respectively. To minimize the risk of compatibility issues, this CL uses the the same protocol conversions logic to CUAS. BUG=246534 TEST=Tested with GoogleJapaneseInput Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208124

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Address comment #

Patch Set 3 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -34 lines) Patch
M ui/base/ime/input_method_tsf.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M ui/base/ime/win/mock_tsf_bridge.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M ui/base/ime/win/mock_tsf_bridge.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/base/ime/win/tsf_bridge.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/base/ime/win/tsf_bridge.cc View 1 2 chunks +17 lines, -28 lines 0 comments Download
M ui/base/ime/win/tsf_text_store.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/ime/win/tsf_text_store.cc View 1 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yohei Yukawa
7 years, 6 months ago (2013-06-21 06:41:09 UTC) #1
Seigo Nonaka
https://codereview.chromium.org/16901011/diff/3001/ui/base/ime/win/tsf_bridge.cc File ui/base/ime/win/tsf_bridge.cc (right): https://codereview.chromium.org/16901011/diff/3001/ui/base/ime/win/tsf_bridge.cc#newcode239 ui/base/ime/win/tsf_bridge.cc:239: nit: please remove https://codereview.chromium.org/16901011/diff/3001/ui/base/ime/win/tsf_text_store.cc File ui/base/ime/win/tsf_text_store.cc (right): https://codereview.chromium.org/16901011/diff/3001/ui/base/ime/win/tsf_text_store.cc#newcode836 ui/base/ime/win/tsf_text_store.cc:836: ...
7 years, 6 months ago (2013-06-21 08:09:53 UTC) #2
Yohei Yukawa
PTAL? https://codereview.chromium.org/16901011/diff/3001/ui/base/ime/win/tsf_bridge.cc File ui/base/ime/win/tsf_bridge.cc (right): https://codereview.chromium.org/16901011/diff/3001/ui/base/ime/win/tsf_bridge.cc#newcode239 ui/base/ime/win/tsf_bridge.cc:239: On 2013/06/21 08:09:53, Seigo Nonaka wrote: > nit: ...
7 years, 6 months ago (2013-06-21 08:26:54 UTC) #3
Seigo Nonaka
lgtm
7 years, 6 months ago (2013-06-21 08:40:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16901011/16001
7 years, 6 months ago (2013-06-22 14:33:09 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-22 15:18:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16901011/22003
7 years, 6 months ago (2013-06-23 02:25:35 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 6 months ago (2013-06-23 07:26:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16901011/22003
7 years, 6 months ago (2013-06-23 11:33:29 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-23 14:10:47 UTC) #10
Message was sent while issue was closed.
Change committed as 208124

Powered by Google App Engine
This is Rietveld 408576698