Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3768)

Unified Diff: media/base/pipeline_impl.cc

Issue 169010: Framework to display disabled mute button when audio fails.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl.cc
===================================================================
--- media/base/pipeline_impl.cc (revision 23449)
+++ media/base/pipeline_impl.cc (working copy)
@@ -688,6 +688,11 @@
void PipelineImpl::BroadcastMessageTask(FilterMessage message) {
DCHECK_EQ(MessageLoop::current(), message_loop_);
+ // TODO(kylep): This is a horribly ugly hack, but we have no better way to log
+ // that audio is not and will not be working.
awong 2009/08/14 20:33:10 File a bug about this and put the bug number into
kylep 2009/08/14 20:48:02 Bug filed: http://crbug.com/19384
+ if (message == media::kMsgDisableAudio)
+ rendered_mime_types_.erase(mime_type::kMajorTypeAudio);
scherkus (not reviewing) 2009/08/14 20:34:44 is this valid? I think erase takes an iterator, b
kylep 2009/08/14 20:48:02 Yeah, I looked it up. It takes either an iterator
scherkus (not reviewing) 2009/08/14 22:28:17 What if the element doesn't exist? I have this fe
+
// Broadcast the message to all filters.
for (FilterVector::iterator iter = filters_.begin();
iter != filters_.end();
« no previous file with comments | « no previous file | webkit/glue/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698