Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: media/filters/stream_parser_factory.cc

Issue 1690063002: Fix mime type mappings when the unified media pipeline is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include MSE fixes. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/mime_util.cc ('K') | « media/base/mime_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/stream_parser_factory.cc
diff --git a/media/filters/stream_parser_factory.cc b/media/filters/stream_parser_factory.cc
index 87b84540bc758053eee8b927e84f07321cfd39b3..c9b3fa9ade987f018f55fed4c86867e36057d489 100644
--- a/media/filters/stream_parser_factory.cc
+++ b/media/filters/stream_parser_factory.cc
@@ -14,6 +14,7 @@
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
+#include "media/base/media.h"
#include "media/base/media_switches.h"
#include "media/formats/mpeg/adts_stream_parser.h"
#include "media/formats/mpeg/mpeg1_audio_stream_parser.h"
@@ -332,12 +333,14 @@ static bool VerifyCodec(
#if defined(OS_ANDROID)
// VP9 is only supported on KitKat+ (API Level 19).
ddorwin 2016/02/11 21:08:24 Should we wrap this comment and logic up in a medi
DaleCurtis 2016/02/11 22:04:53 WDYT about exposing IsCodecSupportedAndroid() on M
ddorwin 2016/02/12 18:45:12 It seems strange to expose that, but it's better t
DaleCurtis 2016/02/13 02:01:42 Done using your suggestion of Is(Vp9|Opus)Supporte
if (codec_info->tag == CodecInfo::HISTOGRAM_VP9 &&
- base::android::BuildInfo::GetInstance()->sdk_int() < 19) {
+ base::android::BuildInfo::GetInstance()->sdk_int() < 19 &&
+ !media::IsUnifiedMediaPipelineEnabled()) {
return false;
}
// Opus is only supported on Lollipop+ (API Level 21).
if (codec_info->tag == CodecInfo::HISTOGRAM_OPUS &&
- base::android::BuildInfo::GetInstance()->sdk_int() < 21) {
+ base::android::BuildInfo::GetInstance()->sdk_int() < 21 &&
+ !media::IsUnifiedMediaPipelineEnabled()) {
return false;
}
#endif
« media/base/mime_util.cc ('K') | « media/base/mime_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698