Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2707)

Unified Diff: cc/raster/task_graph_work_queue.cc

Issue 1690023005: Revert of Refactor signaling in RWP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/raster/task_graph_work_queue.h ('k') | content/renderer/raster_worker_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/raster/task_graph_work_queue.cc
diff --git a/cc/raster/task_graph_work_queue.cc b/cc/raster/task_graph_work_queue.cc
index 0b59822bb4bce10c8a344eff492728b241bf6d48..29474023c6539a17ab44c9cc8b0b0d67645dd635 100644
--- a/cc/raster/task_graph_work_queue.cc
+++ b/cc/raster/task_graph_work_queue.cc
@@ -97,12 +97,9 @@
continue;
// Skip if already running.
- const auto& running_tasks_for_category =
- task_namespace.running_tasks.find(node.category);
- if (running_tasks_for_category != task_namespace.running_tasks.cend() &&
- std::find(running_tasks_for_category->second.cbegin(),
- running_tasks_for_category->second.cend(),
- node.task) != running_tasks_for_category->second.cend())
+ if (std::find(task_namespace.running_tasks.begin(),
+ task_namespace.running_tasks.end(),
+ node.task) != task_namespace.running_tasks.end())
continue;
task_namespace.ready_to_run_tasks[node.category].push_back(PrioritizedTask(
@@ -130,12 +127,9 @@
continue;
// Skip if already running.
- const auto& running_tasks_for_category =
- task_namespace.running_tasks.find(node.category);
- if (running_tasks_for_category != task_namespace.running_tasks.cend() &&
- std::find(running_tasks_for_category->second.cbegin(),
- running_tasks_for_category->second.cend(),
- node.task) != running_tasks_for_category->second.cend())
+ if (std::find(task_namespace.running_tasks.begin(),
+ task_namespace.running_tasks.end(),
+ node.task) != task_namespace.running_tasks.end())
continue;
DCHECK(std::find(task_namespace.completed_tasks.begin(),
@@ -201,7 +195,7 @@
}
// Add task to |running_tasks|.
- task_namespace->running_tasks[category].push_back(task.task);
+ task_namespace->running_tasks.push_back(task.task);
return task;
}
@@ -209,15 +203,13 @@
void TaskGraphWorkQueue::CompleteTask(const PrioritizedTask& completed_task) {
TaskNamespace* task_namespace = completed_task.task_namespace;
scoped_refptr<Task> task(completed_task.task);
- uint16_t category = completed_task.category;
// Remove task from |running_tasks|.
- auto& running_tasks_for_category = task_namespace->running_tasks[category];
- auto it = std::find(running_tasks_for_category.begin(),
- running_tasks_for_category.end(), task);
- DCHECK(it != running_tasks_for_category.end());
- std::swap(*it, running_tasks_for_category.back());
- running_tasks_for_category.pop_back();
+ auto it = std::find(task_namespace->running_tasks.begin(),
+ task_namespace->running_tasks.end(), task);
+ DCHECK(it != task_namespace->running_tasks.end());
+ std::swap(*it, task_namespace->running_tasks.back());
+ task_namespace->running_tasks.pop_back();
// Now iterate over all dependents to decrement dependencies and check if they
// are ready to run.
@@ -285,7 +277,8 @@
// Remove namespace if finished running tasks.
DCHECK_EQ(0u, task_namespace.completed_tasks.size());
- DCHECK(HasFinishedRunningTasksInNamespace(&task_namespace));
+ DCHECK(!HasReadyToRunTasksInNamespace(&task_namespace));
+ DCHECK_EQ(0u, task_namespace.running_tasks.size());
namespaces_.erase(it);
}
« no previous file with comments | « cc/raster/task_graph_work_queue.h ('k') | content/renderer/raster_worker_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698