Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1690023004: added clip visualization to skiaserve (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fixed copy-paste error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -6 lines) Patch
M tools/debugger/SkDebugCanvas.h View 1 3 chunks +10 lines, -3 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 3 chunks +14 lines, -2 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
ethannicholas
4 years, 10 months ago (2016-02-12 16:42:48 UTC) #3
joshualitt
On 2016/02/12 16:42:48, ethannicholas wrote: lgtm
4 years, 10 months ago (2016-02-12 16:47:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690023004/1
4 years, 10 months ago (2016-02-12 16:47:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/6192)
4 years, 10 months ago (2016-02-12 16:51:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690023004/20001
4 years, 10 months ago (2016-02-12 19:33:46 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 20:06:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0a0520afccb9dcad9db2258c936456e69012fa34

Powered by Google App Engine
This is Rietveld 408576698