Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1690013002: Remove --tab-capture-upscale/downscale-quality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Addressed Yuri's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 }; 246 };
247 247
248 const FeatureEntry::Choice kSimpleCacheBackendChoices[] = { 248 const FeatureEntry::Choice kSimpleCacheBackendChoices[] = {
249 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 249 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
250 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 250 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
251 switches::kUseSimpleCacheBackend, "off" }, 251 switches::kUseSimpleCacheBackend, "off" },
252 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 252 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
253 switches::kUseSimpleCacheBackend, "on"} 253 switches::kUseSimpleCacheBackend, "on"}
254 }; 254 };
255 255
256 #if defined(USE_AURA)
257 const FeatureEntry::Choice kTabCaptureUpscaleQualityChoices[] = {
258 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
259 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
260 switches::kTabCaptureUpscaleQuality, "fast" },
261 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
262 switches::kTabCaptureUpscaleQuality, "good" },
263 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
264 switches::kTabCaptureUpscaleQuality, "best" },
265 };
266
267 const FeatureEntry::Choice kTabCaptureDownscaleQualityChoices[] = {
268 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
269 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
270 switches::kTabCaptureDownscaleQuality, "fast" },
271 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
272 switches::kTabCaptureDownscaleQuality, "good" },
273 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
274 switches::kTabCaptureDownscaleQuality, "best" },
275 };
276 #endif
277
278 #if defined(OS_ANDROID) 256 #if defined(OS_ANDROID)
279 const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = { 257 const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = {
280 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 258 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
281 { IDS_FLAGS_READER_MODE_HEURISTICS_MARKUP, 259 { IDS_FLAGS_READER_MODE_HEURISTICS_MARKUP,
282 switches::kReaderModeHeuristics, 260 switches::kReaderModeHeuristics,
283 switches::reader_mode_heuristics::kOGArticle }, 261 switches::reader_mode_heuristics::kOGArticle },
284 { IDS_FLAGS_READER_MODE_HEURISTICS_ADABOOST, 262 { IDS_FLAGS_READER_MODE_HEURISTICS_ADABOOST,
285 switches::kReaderModeHeuristics, 263 switches::kReaderModeHeuristics,
286 switches::reader_mode_heuristics::kAdaBoost }, 264 switches::reader_mode_heuristics::kAdaBoost },
287 { IDS_FLAGS_READER_MODE_HEURISTICS_ALWAYS_ON, 265 { IDS_FLAGS_READER_MODE_HEURISTICS_ALWAYS_ON,
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
1100 #if defined(ENABLE_PRINT_PREVIEW) 1078 #if defined(ENABLE_PRINT_PREVIEW)
1101 {"enable-print-preview-simplify", IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_NAME, 1079 {"enable-print-preview-simplify", IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_NAME,
1102 IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_DESCRIPTION, kOsDesktop, 1080 IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_DESCRIPTION, kOsDesktop,
1103 FEATURE_VALUE_TYPE(PrintPreviewDistiller::kFeature)}, 1081 FEATURE_VALUE_TYPE(PrintPreviewDistiller::kFeature)},
1104 #endif 1082 #endif
1105 #if defined(OS_WIN) 1083 #if defined(OS_WIN)
1106 {"enable-cloud-print-xps", IDS_FLAGS_CLOUD_PRINT_XPS_NAME, 1084 {"enable-cloud-print-xps", IDS_FLAGS_CLOUD_PRINT_XPS_NAME,
1107 IDS_FLAGS_CLOUD_PRINT_XPS_DESCRIPTION, kOsWin, 1085 IDS_FLAGS_CLOUD_PRINT_XPS_DESCRIPTION, kOsWin,
1108 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)}, 1086 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)},
1109 #endif 1087 #endif
1110 #if defined(USE_AURA)
1111 {"tab-capture-upscale-quality", IDS_FLAGS_TAB_CAPTURE_UPSCALE_QUALITY_NAME,
1112 IDS_FLAGS_TAB_CAPTURE_UPSCALE_QUALITY_DESCRIPTION, kOsAll,
1113 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices)},
1114 {"tab-capture-downscale-quality",
1115 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME,
1116 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION, kOsAll,
1117 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)},
1118 #endif
1119 #if defined(TOOLKIT_VIEWS) 1088 #if defined(TOOLKIT_VIEWS)
1120 {"disable-hide-inactive-stacked-tab-close-buttons", 1089 {"disable-hide-inactive-stacked-tab-close-buttons",
1121 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME, 1090 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME,
1122 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION, 1091 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION,
1123 kOsCrOS | kOsWin | kOsLinux, 1092 kOsCrOS | kOsWin | kOsLinux,
1124 SINGLE_DISABLE_VALUE_TYPE( 1093 SINGLE_DISABLE_VALUE_TYPE(
1125 switches::kDisableHideInactiveStackedTabCloseButtons)}, 1094 switches::kDisableHideInactiveStackedTabCloseButtons)},
1126 #endif 1095 #endif
1127 #if defined(ENABLE_SPELLCHECK) 1096 #if defined(ENABLE_SPELLCHECK)
1128 {"enable-spelling-feedback-field-trial", 1097 {"enable-spelling-feedback-field-trial",
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
2016 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 1985 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2017 1986
2018 const FeatureEntry* GetFeatureEntries(size_t* count) { 1987 const FeatureEntry* GetFeatureEntries(size_t* count) {
2019 *count = arraysize(kFeatureEntries); 1988 *count = arraysize(kFeatureEntries);
2020 return kFeatureEntries; 1989 return kFeatureEntries;
2021 } 1990 }
2022 1991
2023 } // namespace testing 1992 } // namespace testing
2024 1993
2025 } // namespace about_flags 1994 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/chrome_restart_request.cc » ('j') | content/browser/compositor/gl_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698