Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1690013002: Remove --tab-capture-upscale/downscale-quality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 }; 243 };
244 244
245 const FeatureEntry::Choice kSimpleCacheBackendChoices[] = { 245 const FeatureEntry::Choice kSimpleCacheBackendChoices[] = {
246 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 246 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
247 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 247 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
248 switches::kUseSimpleCacheBackend, "off" }, 248 switches::kUseSimpleCacheBackend, "off" },
249 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 249 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
250 switches::kUseSimpleCacheBackend, "on"} 250 switches::kUseSimpleCacheBackend, "on"}
251 }; 251 };
252 252
253 #if defined(USE_AURA)
254 const FeatureEntry::Choice kTabCaptureUpscaleQualityChoices[] = {
255 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
256 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
257 switches::kTabCaptureUpscaleQuality, "fast" },
258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
259 switches::kTabCaptureUpscaleQuality, "good" },
260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
261 switches::kTabCaptureUpscaleQuality, "best" },
262 };
263
264 const FeatureEntry::Choice kTabCaptureDownscaleQualityChoices[] = {
265 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
266 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
267 switches::kTabCaptureDownscaleQuality, "fast" },
268 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
269 switches::kTabCaptureDownscaleQuality, "good" },
270 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
271 switches::kTabCaptureDownscaleQuality, "best" },
272 };
273 #endif
274
275 #if defined(OS_ANDROID) 253 #if defined(OS_ANDROID)
276 const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = { 254 const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = {
277 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 255 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
278 { IDS_FLAGS_READER_MODE_HEURISTICS_MARKUP, 256 { IDS_FLAGS_READER_MODE_HEURISTICS_MARKUP,
279 switches::kReaderModeHeuristics, 257 switches::kReaderModeHeuristics,
280 switches::reader_mode_heuristics::kOGArticle }, 258 switches::reader_mode_heuristics::kOGArticle },
281 { IDS_FLAGS_READER_MODE_HEURISTICS_ADABOOST, 259 { IDS_FLAGS_READER_MODE_HEURISTICS_ADABOOST,
282 switches::kReaderModeHeuristics, 260 switches::kReaderModeHeuristics,
283 switches::reader_mode_heuristics::kAdaBoost }, 261 switches::reader_mode_heuristics::kAdaBoost },
284 { IDS_FLAGS_READER_MODE_HEURISTICS_ALWAYS_ON, 262 { IDS_FLAGS_READER_MODE_HEURISTICS_ALWAYS_ON,
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
1114 #if defined(ENABLE_PRINT_PREVIEW) 1092 #if defined(ENABLE_PRINT_PREVIEW)
1115 {"enable-print-preview-simplify", IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_NAME, 1093 {"enable-print-preview-simplify", IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_NAME,
1116 IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_DESCRIPTION, kOsDesktop, 1094 IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_DESCRIPTION, kOsDesktop,
1117 FEATURE_VALUE_TYPE(PrintPreviewDistiller::kFeature)}, 1095 FEATURE_VALUE_TYPE(PrintPreviewDistiller::kFeature)},
1118 #endif 1096 #endif
1119 #if defined(OS_WIN) 1097 #if defined(OS_WIN)
1120 {"enable-cloud-print-xps", IDS_FLAGS_CLOUD_PRINT_XPS_NAME, 1098 {"enable-cloud-print-xps", IDS_FLAGS_CLOUD_PRINT_XPS_NAME,
1121 IDS_FLAGS_CLOUD_PRINT_XPS_DESCRIPTION, kOsWin, 1099 IDS_FLAGS_CLOUD_PRINT_XPS_DESCRIPTION, kOsWin,
1122 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)}, 1100 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)},
1123 #endif 1101 #endif
1124 #if defined(USE_AURA)
1125 {"tab-capture-upscale-quality", IDS_FLAGS_TAB_CAPTURE_UPSCALE_QUALITY_NAME,
1126 IDS_FLAGS_TAB_CAPTURE_UPSCALE_QUALITY_DESCRIPTION, kOsAll,
1127 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices)},
1128 {"tab-capture-downscale-quality",
1129 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME,
1130 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION, kOsAll,
1131 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)},
1132 #endif
1133 #if defined(TOOLKIT_VIEWS) 1102 #if defined(TOOLKIT_VIEWS)
1134 {"disable-hide-inactive-stacked-tab-close-buttons", 1103 {"disable-hide-inactive-stacked-tab-close-buttons",
1135 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME, 1104 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME,
1136 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION, 1105 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION,
1137 kOsCrOS | kOsWin | kOsLinux, 1106 kOsCrOS | kOsWin | kOsLinux,
1138 SINGLE_DISABLE_VALUE_TYPE( 1107 SINGLE_DISABLE_VALUE_TYPE(
1139 switches::kDisableHideInactiveStackedTabCloseButtons)}, 1108 switches::kDisableHideInactiveStackedTabCloseButtons)},
1140 #endif 1109 #endif
1141 #if defined(ENABLE_SPELLCHECK) 1110 #if defined(ENABLE_SPELLCHECK)
1142 {"enable-spelling-feedback-field-trial", 1111 {"enable-spelling-feedback-field-trial",
(...skipping 866 matching lines...) Expand 10 before | Expand all | Expand 10 after
2009 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 1978 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2010 1979
2011 const FeatureEntry* GetFeatureEntries(size_t* count) { 1980 const FeatureEntry* GetFeatureEntries(size_t* count) {
2012 *count = arraysize(kFeatureEntries); 1981 *count = arraysize(kFeatureEntries);
2013 return kFeatureEntries; 1982 return kFeatureEntries;
2014 } 1983 }
2015 1984
2016 } // namespace testing 1985 } // namespace testing
2017 1986
2018 } // namespace about_flags 1987 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698