Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1690013002: Remove --tab-capture-upscale/downscale-quality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address piman's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/chrome_restart_request.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 }; 247 };
248 248
249 const FeatureEntry::Choice kSimpleCacheBackendChoices[] = { 249 const FeatureEntry::Choice kSimpleCacheBackendChoices[] = {
250 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 250 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
251 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 251 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
252 switches::kUseSimpleCacheBackend, "off" }, 252 switches::kUseSimpleCacheBackend, "off" },
253 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 253 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
254 switches::kUseSimpleCacheBackend, "on"} 254 switches::kUseSimpleCacheBackend, "on"}
255 }; 255 };
256 256
257 #if defined(USE_AURA)
258 const FeatureEntry::Choice kTabCaptureUpscaleQualityChoices[] = {
259 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
261 switches::kTabCaptureUpscaleQuality, "fast" },
262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
263 switches::kTabCaptureUpscaleQuality, "good" },
264 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
265 switches::kTabCaptureUpscaleQuality, "best" },
266 };
267
268 const FeatureEntry::Choice kTabCaptureDownscaleQualityChoices[] = {
269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
270 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
271 switches::kTabCaptureDownscaleQuality, "fast" },
272 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
273 switches::kTabCaptureDownscaleQuality, "good" },
274 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
275 switches::kTabCaptureDownscaleQuality, "best" },
276 };
277 #endif
278
279 #if defined(OS_ANDROID) 257 #if defined(OS_ANDROID)
280 const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = { 258 const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = {
281 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 259 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
282 { IDS_FLAGS_READER_MODE_HEURISTICS_MARKUP, 260 { IDS_FLAGS_READER_MODE_HEURISTICS_MARKUP,
283 switches::kReaderModeHeuristics, 261 switches::kReaderModeHeuristics,
284 switches::reader_mode_heuristics::kOGArticle }, 262 switches::reader_mode_heuristics::kOGArticle },
285 { IDS_FLAGS_READER_MODE_HEURISTICS_ADABOOST, 263 { IDS_FLAGS_READER_MODE_HEURISTICS_ADABOOST,
286 switches::kReaderModeHeuristics, 264 switches::kReaderModeHeuristics,
287 switches::reader_mode_heuristics::kAdaBoost }, 265 switches::reader_mode_heuristics::kAdaBoost },
288 { IDS_FLAGS_READER_MODE_HEURISTICS_ALWAYS_ON, 266 { IDS_FLAGS_READER_MODE_HEURISTICS_ALWAYS_ON,
(...skipping 810 matching lines...) Expand 10 before | Expand all | Expand 10 after
1099 #if defined(ENABLE_PRINT_PREVIEW) 1077 #if defined(ENABLE_PRINT_PREVIEW)
1100 {"enable-print-preview-simplify", IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_NAME, 1078 {"enable-print-preview-simplify", IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_NAME,
1101 IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_DESCRIPTION, kOsDesktop, 1079 IDS_FLAGS_DISTILLER_IN_PRINT_PREVIEW_DESCRIPTION, kOsDesktop,
1102 FEATURE_VALUE_TYPE(PrintPreviewDistiller::kFeature)}, 1080 FEATURE_VALUE_TYPE(PrintPreviewDistiller::kFeature)},
1103 #endif 1081 #endif
1104 #if defined(OS_WIN) 1082 #if defined(OS_WIN)
1105 {"enable-cloud-print-xps", IDS_FLAGS_CLOUD_PRINT_XPS_NAME, 1083 {"enable-cloud-print-xps", IDS_FLAGS_CLOUD_PRINT_XPS_NAME,
1106 IDS_FLAGS_CLOUD_PRINT_XPS_DESCRIPTION, kOsWin, 1084 IDS_FLAGS_CLOUD_PRINT_XPS_DESCRIPTION, kOsWin,
1107 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)}, 1085 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)},
1108 #endif 1086 #endif
1109 #if defined(USE_AURA)
1110 {"tab-capture-upscale-quality", IDS_FLAGS_TAB_CAPTURE_UPSCALE_QUALITY_NAME,
1111 IDS_FLAGS_TAB_CAPTURE_UPSCALE_QUALITY_DESCRIPTION, kOsAll,
1112 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices)},
1113 {"tab-capture-downscale-quality",
1114 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME,
1115 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION, kOsAll,
1116 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)},
1117 #endif
1118 #if defined(TOOLKIT_VIEWS) 1087 #if defined(TOOLKIT_VIEWS)
1119 {"disable-hide-inactive-stacked-tab-close-buttons", 1088 {"disable-hide-inactive-stacked-tab-close-buttons",
1120 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME, 1089 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME,
1121 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION, 1090 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION,
1122 kOsCrOS | kOsWin | kOsLinux, 1091 kOsCrOS | kOsWin | kOsLinux,
1123 SINGLE_DISABLE_VALUE_TYPE( 1092 SINGLE_DISABLE_VALUE_TYPE(
1124 switches::kDisableHideInactiveStackedTabCloseButtons)}, 1093 switches::kDisableHideInactiveStackedTabCloseButtons)},
1125 #endif 1094 #endif
1126 #if defined(ENABLE_SPELLCHECK) 1095 #if defined(ENABLE_SPELLCHECK)
1127 {"enable-spelling-feedback-field-trial", 1096 {"enable-spelling-feedback-field-trial",
(...skipping 897 matching lines...) Expand 10 before | Expand all | Expand 10 after
2025 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 1994 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2026 1995
2027 const FeatureEntry* GetFeatureEntries(size_t* count) { 1996 const FeatureEntry* GetFeatureEntries(size_t* count) {
2028 *count = arraysize(kFeatureEntries); 1997 *count = arraysize(kFeatureEntries);
2029 return kFeatureEntries; 1998 return kFeatureEntries;
2030 } 1999 }
2031 2000
2032 } // namespace testing 2001 } // namespace testing
2033 2002
2034 } // namespace about_flags 2003 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/chrome_restart_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698