Add error reporting server to the browser controller

tools/testing/dart/browser_controller.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library browser;
 
 import "dart:async";
 import "dart:core";
 import "dart:io";
 
 import 'android.dart';
@@ skipping 688 matching lines @@
 
   Future<bool> terminate() {
     var futures = [];
     underTermination = true;
     testingServer.underTermination = true;
     for (BrowserTestingStatus status in browserStatus.values) {
       futures.add(status.browser.close());
     }
     return Future.wait(futures).then((values) {
       testingServer.httpServer.close();
+      testingServer.errorReportingServer.close();
       printDoubleReportingTests();
       return !values.contains(false);
     });
   }
 
   Browser getInstance() {
     var browser = new Browser.byName(browserName);
     browser.logger = logger;
     return browser;
   }
@@ skipping 15 matching lines @@
   final String local_ip;
 
   const String driverPath = "/driver";
   const String nextTestPath = "/next_test";
   const String reportPath = "/report";
   const String waitSignal = "WAIT";
   const String terminateSignal = "TERMINATE";
 
   var testCount = 0;
   var httpServer;
+  var errorReportingServer;
   bool underTermination = false;
   bool useIframe = false;
 
   Function testDoneCallBack;
   Function nextTestCallBack;
 
   BrowserTestingServer(this.local_ip, this.useIframe);
 
   Future start() {
     return HttpServer.bind(local_ip, 0).then((createdServer) {
@@ skipping 24 matching lines @@
           if (!underTermination) {
             print("URI ${request.uri}");
             print("Textresponse $textResponse");
             throw "Error returning content to browser: $error";
           }
       });
       }
       void errorHandler(e) {
         if (!underTermination) print("Error occured in httpserver: $e");
       };
+
       httpServer.listen(handler, onError: errorHandler);
-      return true;
+
+      // Set up the error reporting server that enables us to send back
+      // errors from the browser.
+      return HttpServer.bind(local_ip, 0).then((createdReportServer) {
+        errorReportingServer = createdReportServer;
+        void errorReportingHandler(HttpRequest request) {
+          StringBuffer buffer = new StringBuffer();
+          request.transform(new StringDecoder()).listen((data) {
+            buffer.write(data);
+          }, onDone: () {
+              String back = buffer.toString();
+              request.response.headers.set("Access-Control-Allow-Origin", "*");
+
+              request.response.close();
+              DebugLogger.info("Error from browser on : "

[kustermann, 2013/06/13 12:34:04]

Make it DebugLogger.error.

[ricow1, 2013/06/13 12:39:54]

Done.

+                               "${request.uri.path}, data:  $back");

[kustermann, 2013/06/13 12:34:04]

Please catch errors on the "request.response.done/close()" future.

[ricow1, 2013/06/13 12:39:54]

Done.

+          }, onError: (error) { print(error); });
+        }
+        errorReportingServer.listen(errorReportingHandler,
+                                    onError: errorHandler);
+        return true;
+        });

[kustermann, 2013/06/13 12:34:04]

indentation

[ricow1, 2013/06/13 12:39:54]

Done.

     });
   }
 
   void handleReport(HttpRequest request, String browserId, var testId) {
     StringBuffer buffer = new StringBuffer();
     request.transform(new StringDecoder()).listen((data) {
       buffer.write(data);
       }, onDone: () {
         String back = buffer.toString();
         request.response.close();
@@ skipping 20 matching lines @@
       print("Bad browser testing server, you are not started yet. Can't "
             "produce driver url");
       exit(1);
       // This should never happen - exit immediately;
     }
     return "http://$local_ip:${httpServer.port}/driver/$browserId";
   }
 
 
   String getDriverPage(String browserId) {
+    var errorReportingUrl =
+        "http://$local_ip:${errorReportingServer.port}/$browserId";
     String driverContent = """
 <!DOCTYPE html><html>
 <head>
   <title>Driving page</title>
   <script type='text/javascript'>
 
     function startTesting() {
       var number_of_tests = 0;
       var current_id;
       var last_reported_id;
@@ skipping 17 matching lines @@
               if (nextTask != undefined) alert('This is really bad');
               // The task is send to us as:
               // URL#ID
               var split = this.responseText.split('#');
               var nextTask = split[0];
               current_id = split[1];
               did_start = false;
               run(nextTask);
             }
           } else {
-            // We are basically in trouble - do something clever.
+            reportError('Could not contact the server and get a new task');
           }
         }
       }
 
       function getNextTask() {
         var client = new XMLHttpRequest();
         client.onreadystatechange = newTaskHandler;
         client.open('GET', '$nextTestPath/$browserId');
         client.send();
       }
 
       function run(url) {
         number_of_tests++;
         document.getElementById('number').innerHTML = number_of_tests;
         if (use_iframe) {
           embedded_iframe.src = url;
         } else {
           if (testing_window == undefined) {
             testing_window = window.open(url);
           } else {
             testing_window.location = url;
           }
         }
       }
 
+      window.onerror = function (message, url, lineNumber) {
+        if (url) {
+          reportError(url + ':' + lineNumber + ':' + message);
+        } else {
+          reportError(message);
+        }
+      }
+
+      function reportError(msg) {
+        var client = new XMLHttpRequest();
+        function handleReady() {
+          if (this.readyState == this.DONE && this.status != 200) {
+            // We could not report, pop up to notify if running interactively.
+            alert(this.status);
+          }
+        }
+        client.onreadystatechange = handleReady;
+        client.open('POST', '$errorReportingUrl?test=1');
+        client.setRequestHeader('Content-type',
+                                'application/x-www-form-urlencoded');
+        client.send(msg);
+      }
+
       function reportMessage(msg) {
         if (msg == 'STARTING') {
           did_start = true;
           return;
         }
         var client = new XMLHttpRequest();
         function handleReady() {
           if (this.readyState == this.DONE) {
-            if (last_reported_id != current_id && did_start) {
-              getNextTask();
-              last_reported_id = current_id;
+            if (this.status == 200) {
+              if (last_reported_id != current_id && did_start) {
+                getNextTask();
+                last_reported_id = current_id;
+              }
+            } else {
+              reportError('Error sending result to server');
             }
           }
         }
         client.onreadystatechange = handleReady;
         // If did_start is false it means that we did actually set the url on
         // the testing_window, but this is a report left in the event loop or
         // a callback because the page did not load yet.
         // In both cases this is a double report from the last test.
         var posting_id = did_start ? current_id : last_reported_id;
         client.open('POST', '$reportPath/${browserId}?id=' + posting_id);
         client.setRequestHeader('Content-type',
                                 'application/x-www-form-urlencoded');
         client.send(msg);
-        // TODO(ricow) add error handling to somehow report the fact that
-        // we could not send back a result.
       }
 
       function messageHandler(e) {
         var msg = e.data;
         if (typeof msg != 'string') return;
         reportMessage(msg);
       }
 
       window.addEventListener('message', messageHandler, false);
       waitForDone = false;
 
       getNextTask();
     }
 
   </script>
 </head>
   <body onload="startTesting()">
     Dart test driver, number of tests: <div id="number"></div>
     <iframe id="embedded_iframe"></iframe>
   </body>
 </html>
 """;
     return driverContent;
   }
 }