Added flag for alternate launcher settings (remaining changes to come).

Added flag for alternate launcher settings (remaining changes to come). 

Alter height of shelf when flag is set. 

BUG=244983
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206348

[Harry McCleave, 2013-06-13 03:01:50]

Please review when you get a chance, just the first in about 5 cl's I think to
implement this feature.

[James Cook, 2013-06-13 15:55:30]

LGTM with some comments

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc
File ash/ash_switches.cc (right):

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc#newcode124
ash/ash_switches.cc:124: // crbug's [244983, 244990, 244994, 245005, 245012]
I would explain briefly the changes here, rather than referencing 5 different
bugs.  Just copy-paste the titles or something.  I usually only reference a
single bug, and only if it's a relatively complex issue.  (This avoids the
reader having to switch into their browser and look up the details of the
issue.)

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc#newcode125
ash/ash_switches.cc:125: const char kAshUseAlternateShelfLayout[] =
"ash-use-alt-shelf";
Should this be ash-use-alternate-shelf to be more similar to the variable name? 
I hate abbreviations.

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc#newcode164
ash/ash_switches.cc:164: bool UseAlternateShelfLayout() {
I like this pattern of a UseFoo() function.

https://codereview.chromium.org/16900002/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/16900002/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6158: +          Alternative Shelf Layout
I prefer sentence capitalization "Alternative shelf layout".  Sadly we are
inconsistent in about:flags

[Harry McCleave, 2013-06-13 22:30:42]

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc
File ash/ash_switches.cc (right):

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc#newcode124
ash/ash_switches.cc:124: // crbug's [244983, 244990, 244994, 245005, 245012]
On 2013/06/13 15:55:30, James Cook (Chromium) wrote:
> I would explain briefly the changes here, rather than referencing 5 different
> bugs.  Just copy-paste the titles or something.  I usually only reference a
> single bug, and only if it's a relatively complex issue.  (This avoids the
> reader having to switch into their browser and look up the details of the
> issue.)

Done.

https://codereview.chromium.org/16900002/diff/1/ash/ash_switches.cc#newcode125
ash/ash_switches.cc:125: const char kAshUseAlternateShelfLayout[] =
"ash-use-alt-shelf";
On 2013/06/13 15:55:30, James Cook (Chromium) wrote:
> Should this be ash-use-alternate-shelf to be more similar to the variable
name? 
> I hate abbreviations.

Done.

[commit-bot: I haz the power, 2013-06-13 22:31:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/16900002/5001

[commit-bot: I haz the power, 2013-06-14 07:08:32]

Change committed as 206348