Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1689993002:
[Interpreter] Remove some Ignition skips from mjsunit and cctest (Closed)
Description[Interpreter] Remove some Ignition skips from mjsunit and cctest
Remove some Ignition skips in mjsunit and cctest, and replace a few
others with fails now that the there is more debugger support.
BUG=v8:4680
LOG=N
Committed: https://crrev.com/14fa0fa831a95d548818d4fa6315c52033dcbbdd
Cr-Commit-Position: refs/heads/master@{#33932}
Patch Set 1 #Patch Set 2 : Fix dcheck_always_on #Patch Set 3 : Remove cctest skips too #
Messages
Total messages: 27 (14 generated)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689993002/1
rmcilroy@chromium.org changed reviewers: + yangguo@chromium.org
Yang, ptal - just updating some test expectations after your debug changes. Note: at the moment we skip debug-* and a bunch of other explicit debug tests in the ignition variant. When you think we are far enough about along in support, please remove these skips and add any remaining failures to the expectations.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13622) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1247) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689993002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13628) v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689993002/40001
Description was changed from ========== [Interpreter] Replace skips with fails in mjsunit. Replaces some skips with fails in mjsunit tests now that the debugger fails in different places. BUG=v8:4680 LOG=N ========== to ========== [Interpreter] Remove some Ignition skips from mjsunit and cctest Remove some Ignition skips in mjsunit and cctest, and replace a few others with fails now that the there is more debugger support. BUG=v8:4680 LOG=N ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/1260) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689993002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/02/11 22:32:27, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. lgtm.
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689993002/60001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Remove some Ignition skips from mjsunit and cctest Remove some Ignition skips in mjsunit and cctest, and replace a few others with fails now that the there is more debugger support. BUG=v8:4680 LOG=N ========== to ========== [Interpreter] Remove some Ignition skips from mjsunit and cctest Remove some Ignition skips in mjsunit and cctest, and replace a few others with fails now that the there is more debugger support. BUG=v8:4680 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Remove some Ignition skips from mjsunit and cctest Remove some Ignition skips in mjsunit and cctest, and replace a few others with fails now that the there is more debugger support. BUG=v8:4680 LOG=N ========== to ========== [Interpreter] Remove some Ignition skips from mjsunit and cctest Remove some Ignition skips in mjsunit and cctest, and replace a few others with fails now that the there is more debugger support. BUG=v8:4680 LOG=N Committed: https://crrev.com/14fa0fa831a95d548818d4fa6315c52033dcbbdd Cr-Commit-Position: refs/heads/master@{#33932} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/14fa0fa831a95d548818d4fa6315c52033dcbbdd Cr-Commit-Position: refs/heads/master@{#33932} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
