Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1689953003: Fixes for running a full application snapshot: (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes for running a full application snapshot: - Eagerly load deferred libraries when running with full application snapshot. - Do not call ErrorExit when reading of the snapshot fails as it assumes an Isolate has been created - Generate a full application snapshot even when there are runtime errors (only compilation errors or VM restarts do not trigger generation of the snapshot) R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4f24d17fef117981f58586d3065f0bf9ac6173e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M runtime/bin/main.cc View 3 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 10 months ago (2016-02-12 00:09:18 UTC) #2
rmacnak
lgtm
4 years, 10 months ago (2016-02-12 18:44:53 UTC) #3
siva
4 years, 10 months ago (2016-02-12 18:48:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f24d17fef117981f58586d3065f0bf9ac6173e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698