Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168993002: Move encryptor API out of webdata. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
bcwhite, Lei Zhang, Jói
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, dyu1, benquan, tfarina, haitaol+watch_chromium.org, Dane Wallinga, browser-components-watch_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Move encryptor API out of webdata. This justs moves encryptor out of components/webdata/encryptor one layer up to components/encryptor. BUG=341293 TEST=None R=thestig@chromium.org,joi@chromium.org,bcwhite@chromium.org TBR=rvargas Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252563

Patch Set 1 #

Patch Set 2 : add encryptor.gypi - forgot that :/ #

Patch Set 3 : ios fix #

Total comments: 8

Patch Set 4 : rm unused includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1131 lines) Patch
M chrome/browser/DEPS View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/in_process_importer_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/cookie_store_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/logins_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A components/encryptor.gypi View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A + components/encryptor/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/encryptor/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/encryptor/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/encryptor/encryptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/encryptor/encryptor_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/encryptor/encryptor_password_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/encryptor/encryptor_password_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + components/encryptor/encryptor_password_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/encryptor/encryptor_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/encryptor/encryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/encryptor/encryptor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/encryptor/ie7_password_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/encryptor/ie7_password_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/encryptor/ie7_password_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/login_database_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/webdata/token_service_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/system_encryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/system_encryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata.gypi View 1 chunk +0 lines, -36 lines 0 comments Download
D components/webdata/encryptor/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/webdata/encryptor/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/webdata/encryptor/README View 1 chunk +0 lines, -4 lines 0 comments Download
D components/webdata/encryptor/encryptor.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/webdata/encryptor/encryptor_mac.mm View 1 chunk +0 lines, -150 lines 0 comments Download
D components/webdata/encryptor/encryptor_password_mac.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/webdata/encryptor/encryptor_password_mac.mm View 1 chunk +0 lines, -79 lines 0 comments Download
D components/webdata/encryptor/encryptor_password_mac_unittest.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D components/webdata/encryptor/encryptor_posix.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D components/webdata/encryptor/encryptor_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D components/webdata/encryptor/encryptor_win.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D components/webdata/encryptor/ie7_password_unittest_win.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D components/webdata/encryptor/ie7_password_win.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/webdata/encryptor/ie7_password_win.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M google_apis/gcm/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
6 years, 10 months ago (2014-02-16 21:21:16 UTC) #1
Jói
LGTM https://codereview.chromium.org/168993002/diff/230001/components/encryptor/encryptor_password_mac.h File components/encryptor/encryptor_password_mac.h (right): https://codereview.chromium.org/168993002/diff/230001/components/encryptor/encryptor_password_mac.h#newcode16 components/encryptor/encryptor_password_mac.h:16: class EncryptorPassword { Please move code in this ...
6 years, 10 months ago (2014-02-17 11:14:21 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/168993002/diff/230001/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/168993002/diff/230001/chrome/browser/services/gcm/gcm_profile_service.cc#newcode28 chrome/browser/services/gcm/gcm_profile_service.cc:28: #include "components/encryptor/encryptor.h" Not used? https://codereview.chromium.org/168993002/diff/230001/chrome/browser/signin/signin_manager_unittest.cc File chrome/browser/signin/signin_manager_unittest.cc (right): ...
6 years, 10 months ago (2014-02-18 01:48:55 UTC) #3
bcwhite
https://codereview.chromium.org/168993002/diff/230001/components/encryptor/encryptor.h File components/encryptor/encryptor.h (right): https://codereview.chromium.org/168993002/diff/230001/components/encryptor/encryptor.h#newcode15 components/encryptor/encryptor.h:15: class Encryptor { It was suggested to change the ...
6 years, 10 months ago (2014-02-18 15:02:52 UTC) #4
tfarina
https://codereview.chromium.org/168993002/diff/230001/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/168993002/diff/230001/chrome/browser/services/gcm/gcm_profile_service.cc#newcode28 chrome/browser/services/gcm/gcm_profile_service.cc:28: #include "components/encryptor/encryptor.h" On 2014/02/18 01:48:56, Lei Zhang (OOO starting ...
6 years, 10 months ago (2014-02-21 02:14:40 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-21 02:14:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/168993002/680001
6 years, 10 months ago (2014-02-21 02:15:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:45:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=231351
6 years, 10 months ago (2014-02-21 02:45:41 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-21 13:04:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/168993002/680001
6 years, 10 months ago (2014-02-21 13:05:32 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 15:40:14 UTC) #12
Message was sent while issue was closed. 
Change committed as 252563

Powered by Google App Engine
This is Rietveld 408576698