Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1689903002: Fix adopt-iframe-src-attr-after-remove.html flaky failure, attempt 2. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix adopt-iframe-src-attr-after-remove.html flaky failure, attempt 2. Test still flaky following r374872; make the ordering between timer operations explicit -- requiring the onload's GC to have completed before running the main part of this test. (Semi-blind attempt, unable to reproduce locally.) R=haraken BUG=584209 Committed: https://crrev.com/6b18e5303e6c989299b5457474e034eba6521f4d Cr-Commit-Position: refs/heads/master@{#374889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/misc/adopt-iframe-src-attr-after-remove.html View 1 chunk +21 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look. Bots didn't consistently cycle green with r374872, I suspect due to ...
4 years, 10 months ago (2016-02-11 10:54:31 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-11 10:57:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689903002/1
4 years, 10 months ago (2016-02-11 11:00:14 UTC) #6
sof
(no flakiness seen on CQ bots involved.)
4 years, 10 months ago (2016-02-11 12:14:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 13:27:50 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:35:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b18e5303e6c989299b5457474e034eba6521f4d
Cr-Commit-Position: refs/heads/master@{#374889}

Powered by Google App Engine
This is Rietveld 408576698