Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1689873004: Invalidate :-webkit-any-link for visited state changes. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate :-webkit-any-link for visited state changes. We did style invalidation for :visited and :link, but UA style uses color: -webkit-link with :-webkit-any-link and let -webkit-link be translated into two different colors in the implementation instead of using :visited and :link in the stylesheet. Adding style invalidation of :-webkit-link as well. We already did that for attribute changes on <a> and <svg:a>. R=tkent@chromium.org BUG=586190 Committed: https://crrev.com/d60945722ccecc04d8a60d4a68feaca4baad6e30 Cr-Commit-Position: refs/heads/master@{#375138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/VisitedLinkState.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689873004/1
4 years, 10 months ago (2016-02-11 23:43:38 UTC) #2
rune
As usual I don't have a test for :visited. components/visitedlink is not included in webkit_unit_tests ...
4 years, 10 months ago (2016-02-11 23:52:43 UTC) #3
tkent
lgtm
4 years, 10 months ago (2016-02-11 23:58:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 01:38:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689873004/1
4 years, 10 months ago (2016-02-12 06:32:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 06:37:25 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d60945722ccecc04d8a60d4a68feaca4baad6e30
Cr-Commit-Position: refs/heads/master@{#375138}

Powered by Google App Engine
This is Rietveld 408576698