Fix PEM error checking

Fix PEM error checking

While reading PEM data, if we encounter PEM_R_NO_START_LINE, and some
data has been read successfully, we assume that we have reached the
end of the data.

If we encounter PEM_R_NO_START_LINE, and no data has been read
successfully, we assume that the data is not PEM, and we try instead
to read it as PKCS12.

Otherwise, we assume it is malformed PEM, and propagate an error.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/53dec5d35fae91becee40b635a7ff8cda9edf9d9

[zra, 2016-02-11 07:58:37]

zra@google.com changed reviewers:
+ whesse@google.com

[zra, 2016-02-12 15:57:38]

Ping

[zra, 2016-02-12 15:57:50]

zra@google.com changed reviewers:
+ iposva@google.com

[Bill Hesse, 2016-02-12 23:45:30]

lgtm

[zra, 2016-02-13 03:01:51]

Description was changed from

==========
Fix PEM error checking

While reading PEM data, if we encounter PEM_R_NO_START_LINE, and some
data has been read successfully, we assume that we have reached the
end of the data.

If we encounter PEM_R_NO_START_LINE, and no data has been read
successfully, we assume that the data is not PEM, and we try instead
to read it as PKCS12.

Otherwise, we assume it is malformed PEM, and propagate an error.
==========

to

==========
Fix PEM error checking

While reading PEM data, if we encounter PEM_R_NO_START_LINE, and some
data has been read successfully, we assume that we have reached the
end of the data.

If we encounter PEM_R_NO_START_LINE, and no data has been read
successfully, we assume that the data is not PEM, and we try instead
to read it as PKCS12.

Otherwise, we assume it is malformed PEM, and propagate an error.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53dec5d35fae91becee40b635a7ff8cda9edf9d9
==========

[zra, 2016-02-13 03:01:52]

Committed patchset #2 (id:20001) manually as
53dec5d35fae91becee40b635a7ff8cda9edf9d9 (presubmit successful).