Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1689873002: Enable inspector tests disabled when dart:html was switched to JS interop. (Closed)

Created:
4 years, 10 months ago by Jacob
Modified:
4 years, 10 months ago
Reviewers:
Alan Knight, terry
CC:
reviews+dom_dartlang.org
Target Ref:
refs/remotes/git-svn
Project:
blink
Visibility:
Public.

Description

Enable inspector tests disabled when dart:html was switched to JS interop. BUG= Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=202775

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -70 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M LayoutTests/dart/dom/Console.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/dart/dom/Console-expected.txt View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/dart/inspector/debugger-eval-on-call-frame.html View 5 chunks +25 lines, -18 lines 0 comments Download
M LayoutTests/dart/inspector/debugger-eval-on-call-frame-expected.txt View 2 chunks +19 lines, -3 lines 0 comments Download
M LayoutTests/dart/inspector/deferred-import.html View 2 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/dart/inspector/evaluate-in-console.html View 1 3 chunks +15 lines, -0 lines 0 comments Download
M LayoutTests/dart/inspector/evaluate-in-console-expected.txt View 1 5 chunks +13 lines, -5 lines 0 comments Download
M LayoutTests/dart/inspector/scope-variables.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/dart/DartHandleProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/dart/DartHandleProxy.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/bindings/core/dart/DartInjectedScript.cpp View 2 chunks +4 lines, -22 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Jacob
TBR Get inspector working Fixes bugs https://github.com/dart-lang/sdk/issues/24447 and https://github.com/dart-lang/sdk/issues/25756
4 years, 10 months ago (2016-02-11 02:39:54 UTC) #2
Jacob
4 years, 10 months ago (2016-02-11 02:40:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 202775 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698