Introduce BeforeCallEnteredCallback.

Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before the call has been made.
Added Isolate* parameter to CallCompletedCallback, marking previous one as deprecated.

BUG=chromium:585949
LOG=Y

Committed: https://crrev.com/0e9ea48c469334b284f3b8d43c432696840206f4
Cr-Commit-Position: refs/heads/master@{#34167}

[dgozman, 2016-02-11 01:28:42]

Description was changed from

==========
Introduce BeforeCallEnteredCallback.

BUG=chromium:585949
LOG=Y
==========

to

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.

BUG=chromium:585949
LOG=Y
==========

[dgozman, 2016-02-11 01:31:22]

dgozman@chromium.org changed reviewers:
+ adamk@chromium.org, jochen@chromium.org

[dgozman, 2016-02-11 01:31:22]

Could you please take a look?

This is a first patch for V8RecursionScope -> v8::MicrotasksScope migration, a
part of standalone v8 inspector effort.

Blink counterpart: https://codereview.chromium.org/1690823003/.

[dgozman, 2016-02-11 02:08:49]

https://codereview.chromium.org/1689863002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1689863002/diff/1/src/api.cc#newcode167
src/api.cc:167: if (do_callback_) isolate_->FireBeforeCallEnteredCallback();
I think I'd move this call after context->Enter() so that embedder can check in
which context we are about to execute.

[adamk, 2016-02-11 20:04:36]

I'd like to wait for Jochen to return and take a look at the overall plan before
doing detailed code review.

[jochen (gone - plz use gerrit), 2016-02-17 12:58:48]

Adam, did you get to see the overall plan?

https://codereview.chromium.org/1689863002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1689863002/diff/1/include/v8.h#newcode5013
include/v8.h:5013: typedef void (*BeforeCallEnteredCallback)(Isolate*);
what's the reason we need an isolate ptr here, but not on the call completed
callback?

[dgozman, 2016-02-17 16:51:12]

The overall plan is described in the bug:
https://code.google.com/p/chromium/issues/detail?id=585949

https://codereview.chromium.org/1689863002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1689863002/diff/1/include/v8.h#newcode5013
include/v8.h:5013: typedef void (*BeforeCallEnteredCallback)(Isolate*);
On 2016/02/17 12:58:48, jochen wrote:
> what's the reason we need an isolate ptr here, but not on the call completed
> callback?

Passing isolate replaces the need to call Isolate::GetCurrent from inside the
callback. I think that's a cleaner contract which does not assume anything about
entered isolate before making a call.

[jochen (gone - plz use gerrit), 2016-02-18 13:48:38]

https://codereview.chromium.org/1689863002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1689863002/diff/1/include/v8.h#newcode5014
include/v8.h:5014: typedef void (*CallCompletedCallback)();
can you add an isolate* parameter here as well then?

you can typedef void (*DeprecatedCallCompletedCallback)(); and then overload the
methods to add and remove the callback.

Due to C calling conventions, it's safe to reinterpret_cast<> the deprecated to
a new one internally

[dgozman, 2016-02-19 01:59:36]

Description was changed from

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.

BUG=chromium:585949
LOG=Y
==========

to

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.
Added Isolate* parameter to CallCompletedCallback, marking previous one as
deprecated.

BUG=chromium:585949
LOG=Y
==========

[dgozman, 2016-02-19 01:59:42]

https://codereview.chromium.org/1689863002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1689863002/diff/1/include/v8.h#newcode5014
include/v8.h:5014: typedef void (*CallCompletedCallback)();
On 2016/02/18 13:48:38, jochen wrote:
> can you add an isolate* parameter here as well then?
> 
> you can typedef void (*DeprecatedCallCompletedCallback)(); and then overload
the
> methods to add and remove the callback.
> 
> Due to C calling conventions, it's safe to reinterpret_cast<> the deprecated
to
> a new one internally

Done.

[jochen (gone - plz use gerrit), 2016-02-19 14:44:57]

lgtm with comment

https://codereview.chromium.org/1689863002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1689863002/diff/20001/include/v8.h#newcode5838
include/v8.h:5838: V8_DEPRECATED(
you'll need V8_DEPRECATE_SOON - otherwise blink won't compile anymore for now

[dgozman, 2016-02-19 16:56:00]

https://codereview.chromium.org/1689863002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1689863002/diff/20001/include/v8.h#newcode5838
include/v8.h:5838: V8_DEPRECATED(
On 2016/02/19 14:44:57, jochen wrote:
> you'll need V8_DEPRECATE_SOON - otherwise blink won't compile anymore for now

Done.

[dgozman, 2016-02-19 16:56:05]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-02-19 16:56:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1689863002/#ps40001
(title: "V8_DEPRECATE_SOON")

[commit-bot: I haz the power, 2016-02-19 16:56:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689863002/40001

[commit-bot: I haz the power, 2016-02-19 18:48:13]

Description was changed from

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.
Added Isolate* parameter to CallCompletedCallback, marking previous one as
deprecated.

BUG=chromium:585949
LOG=Y
==========

to

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.
Added Isolate* parameter to CallCompletedCallback, marking previous one as
deprecated.

BUG=chromium:585949
LOG=Y
==========

[commit-bot: I haz the power, 2016-02-19 18:48:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-19 18:48:52]

Description was changed from

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.
Added Isolate* parameter to CallCompletedCallback, marking previous one as
deprecated.

BUG=chromium:585949
LOG=Y
==========

to

==========
Introduce BeforeCallEnteredCallback.

This new callback is similar to CallCompletedCallback, but is executed before
the call has been made.
Added Isolate* parameter to CallCompletedCallback, marking previous one as
deprecated.

BUG=chromium:585949
LOG=Y

Committed: https://crrev.com/0e9ea48c469334b284f3b8d43c432696840206f4
Cr-Commit-Position: refs/heads/master@{#34167}
==========

[commit-bot: I haz the power, 2016-02-19 18:48:53]

Patchset 3 (id:??) landed as
https://crrev.com/0e9ea48c469334b284f3b8d43c432696840206f4
Cr-Commit-Position: refs/heads/master@{#34167}