Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: base/metrics/histogram_unittest.cc

Issue 1689833002: Add ownership-transfer to histogram management calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_persistence.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_unittest.cc
diff --git a/base/metrics/histogram_unittest.cc b/base/metrics/histogram_unittest.cc
index beb6a71ede63c81168a851d099c9afbe8f2918bb..63c50a6b832551363f33836d99c5518d328c0b4a 100644
--- a/base/metrics/histogram_unittest.cc
+++ b/base/metrics/histogram_unittest.cc
@@ -189,23 +189,23 @@ TEST_P(HistogramTest, PersistentTest) {
0, std::string(), false);
recovery.CreateIterator(&iter);
- recovered.reset(GetNextPersistentHistogram(&recovery, &iter));
+ recovered = GetNextPersistentHistogram(&recovery, &iter);
ASSERT_TRUE(recovered);
recovered->CheckName("TestHistogram");
- recovered.reset(GetNextPersistentHistogram(&recovery, &iter));
+ recovered = GetNextPersistentHistogram(&recovery, &iter);
ASSERT_TRUE(recovered);
recovered->CheckName("TestLinearHistogram");
- recovered.reset(GetNextPersistentHistogram(&recovery, &iter));
+ recovered = GetNextPersistentHistogram(&recovery, &iter);
ASSERT_TRUE(recovered);
recovered->CheckName("TestBooleanHistogram");
- recovered.reset(GetNextPersistentHistogram(&recovery, &iter));
+ recovered = GetNextPersistentHistogram(&recovery, &iter);
ASSERT_TRUE(recovered);
recovered->CheckName("TestCustomHistogram");
- recovered.reset(GetNextPersistentHistogram(&recovery, &iter));
+ recovered = GetNextPersistentHistogram(&recovery, &iter);
EXPECT_FALSE(recovered);
// Use standard macros (but with fixed samples)
« no previous file with comments | « base/metrics/histogram_persistence.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698