Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 168983003: change PictureRecord (and its private subclasses) to take size instead of device (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
scroggo, mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

change PictureRecord (and its private subclasses) to take size instead of device BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M src/core/SkBBoxHierarchyRecord.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkBBoxRecord.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
all part of the never-ending-struggle to hide SkDevice (esp. when it aint doing anything)
6 years, 10 months ago (2014-02-16 21:59:45 UTC) #1
mtklein
lgtm
6 years, 10 months ago (2014-02-17 13:03:11 UTC) #2
scroggo
On 2014/02/17 13:03:11, mtklein wrote: > lgtm lgtm
6 years, 10 months ago (2014-02-17 14:19:23 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-17 14:28:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/168983003/1
6 years, 10 months ago (2014-02-17 14:28:11 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 15:28:09 UTC) #6
Message was sent while issue was closed.
Change committed as 13477

Powered by Google App Engine
This is Rietveld 408576698