Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1689823003: Revert of Oilpan: Decommit backing storage of CallbackStacks (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
keishi, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Oilpan: Decommit backing storage of CallbackStacks (patchset #7 id:120001 of https://codereview.chromium.org/1686943002/ ) Reason for revert: This CL will cause page faults at every marking phase. Marking must be super fast, so we need to reconsider the approach. Original issue's description: > Oilpan: Decommit backing storage of CallbackStacks > > CallbackStacks are used only while Oilpan's GC is doing marking & weak processing. > However, currently each CallbackStack continues retaining one Block forever. > > This wastes memory a lot. Oilpan has 4 global CallbackStacks and 1 CallbackStack per thread. > Each Block consumes 8192 * sizeof(Item) = 128 KB. This means that Oilpan wastes 128 KB * (4 + # of threads). > When I start Chrome's new tab page, it creates 18 CallbackStacks, > meaning that it wastes 2.3 MB of memory. > > This CL removes the waste by discarding system pages of the Block after finishing every GC phase. > > BUG= > > Committed: https://crrev.com/34393519671e62e5a66602736899b94ad33dd45a > Cr-Commit-Position: refs/heads/master@{#374674} TBR=keishi@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d06acbf2093b7ffb8fb03b721debdd06ffcabafc Cr-Commit-Position: refs/heads/master@{#374868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -61 lines) Patch
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 4 chunks +22 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.cpp View 3 chunks +15 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 4 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
Created Revert of Oilpan: Decommit backing storage of CallbackStacks
4 years, 10 months ago (2016-02-11 06:31:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689823003/1
4 years, 10 months ago (2016-02-11 06:32:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 06:33:12 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d06acbf2093b7ffb8fb03b721debdd06ffcabafc
Cr-Commit-Position: refs/heads/master@{#374868}

Powered by Google App Engine
This is Rietveld 408576698