Issue 1689753002: Set CRWWebViewContentView's size before resetting scroll proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1689753002: Set CRWWebViewContentView's size before resetting scroll proxy. (Closed)

Created:
4 years, 10 months ago by kkhorimoto

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

More Reviews

Description

Set CRWWebViewContentView's size before resetting scroll proxy. Because CRWWebViewContentView's frame was CGRectZero when the scroll proxy's backing UIScrollView was reset, CRWWebViewScrollViewProxyObservers were mistakenly resetting the web view's frame to an invalid frame (negative values for size dimensions). This was causing various rendering issues, including an incorrect scroll offset for links opened in new tabs and broken tap handling for "Read More" links on cnn.com. BUG=577793, 574996 Review URL: https://codereview.chromium.org/1682873002 Cr-Commit-Position: refs/heads/master@{#374581} (cherry picked from commit c47dcc4e47d42932d126d80d5aa740cf8470280a)

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -24 lines)			Patch
M	ios/web/web_state/ui/crw_web_controller_container_view.mm	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	ios/web/web_state/ui/crw_web_controller_unittest.mm	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	ios/web/web_state/ui/crw_web_view_content_view.mm	View	1 chunk	+14 lines, -11 lines	0 comments	Download
M	ios/web/web_state/ui/crw_wk_web_view_web_controller.mm	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kkhorimoto

4 years, 10 months ago (2016-02-10 19:47:40 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
ba8068db431e8ab42ce641b4507b6d27f5440af8.

Expand Messages | Collapse Messages