Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168973002: Drop [LegacyImplementedInBaseClass] from SVGTests IDL interface (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Drop [LegacyImplementedInBaseClass] from SVGTests IDL interface Drop [LegacyImplementedInBaseClass] from SVGTests IDL interface by refactoring the code a little bit. R=haraken, pdr NOTRY=true BUG=344224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/core/svg/SVGTests.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTests.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Inactive
6 years, 10 months ago (2014-02-16 20:58:51 UTC) #1
pdr.
On 2014/02/16 20:58:51, Chris Dumez wrote: LGTM
6 years, 10 months ago (2014-02-16 22:29:48 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-16 22:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168973002/1
6 years, 10 months ago (2014-02-16 22:29:59 UTC) #4
haraken
LGTM
6 years, 10 months ago (2014-02-16 23:19:40 UTC) #5
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 01:30:12 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 01:30:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 01:41:01 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12646
6 years, 10 months ago (2014-02-17 01:41:01 UTC) #9
pdr.
On 2014/02/17 01:41:01, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-17 01:42:18 UTC) #10
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-17 01:42:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168973002/1
6 years, 10 months ago (2014-02-17 01:42:40 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 01:42:52 UTC) #13
Message was sent while issue was closed. 
Change committed as 167251

Powered by Google App Engine
This is Rietveld 408576698