Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1689723002: Make get_toolchain_if_necessary.py work on Mac again (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
4 years, 10 months ago (2016-02-10 18:00:05 UTC) #1
Nico
lgtm, thanks!
4 years, 10 months ago (2016-02-10 18:29:22 UTC) #2
Sébastien Marchand
lgtm (sorry for that, didn't realized that the Win toolchain was used on non-Win platforms)
4 years, 10 months ago (2016-02-10 18:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689723002/1
4 years, 10 months ago (2016-02-10 19:06:35 UTC) #5
scottmg
On 2016/02/10 18:31:52, Sébastien Marchand wrote: > lgtm (sorry for that, didn't realized that the ...
4 years, 10 months ago (2016-02-10 19:07:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 19:09:02 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298720

Powered by Google App Engine
This is Rietveld 408576698