Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1689693002: Supress deprecation warnings in ClearSyncDataPreferences (Closed)

Created:
4 years, 10 months ago by msramek
Modified:
4 years, 10 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supress deprecation warnings in ClearSyncDataPreferences For backward compatibility, ClearSyncDataPreferences uses both versions of the onAttach() method - the deprecated one, which refers to Activity, and the new one, which refers to Context. Supress the deprecation warning of the former. See crbug.com/585548 for more details. BUG=585548 Committed: https://crrev.com/186ed42f767bdd0581df79269cc31ad808e7a15b Cr-Commit-Position: refs/heads/master@{#374682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataPreferences.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
msramek
Hi Max, can you have a quick look? This is the bug that you reported ...
4 years, 10 months ago (2016-02-10 17:06:43 UTC) #2
maxbogue
lgtm! Thanks for figuring this out.
4 years, 10 months ago (2016-02-10 17:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689693002/1
4 years, 10 months ago (2016-02-10 17:48:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 17:55:53 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 17:57:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/186ed42f767bdd0581df79269cc31ad808e7a15b
Cr-Commit-Position: refs/heads/master@{#374682}

Powered by Google App Engine
This is Rietveld 408576698