SkDocument: remove use of SkTArray (part 1/3).

SkDocument: remove use of SkTArray (part 1/3).

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689683002

Committed: https://skia.googlesource.com/skia/+/7001576c7160e20c9c9db2fbe947408989027d66

[hal.canary, 2016-02-10 15:57:25]

Description was changed from

==========
SkDocument: remove use of SkTArray (part 1/3).
==========

to

==========
SkDocument: remove use of SkTArray (part 1/3).
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-02-10 15:58:27]

halcanary@google.com changed reviewers:
+ bungeman@google.com, reed@google.com

[hal.canary, 2016-02-10 15:58:27]

PTAL

part 2/3 is to switch chrome over to new interface.

part 3/3 is to remove deprecated version.

[hal.canary, 2016-02-10 16:17:12]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 16:17:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689683002/1

[hal.canary, 2016-02-10 16:17:33]

Description was changed from

==========
SkDocument: remove use of SkTArray (part 1/3).
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkDocument: remove use of SkTArray (part 1/3).

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-02-10 16:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:18:22]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[hal.canary, 2016-02-10 16:32:21]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 16:32:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689683002/20001

[commit-bot: I haz the power, 2016-02-10 16:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:34:45]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bungeman-skia, 2016-02-10 16:46:48]

https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument...
include/core/SkDocument.h:134: *      std::vector<SkDocument::Attribute> info;
If using vector here, should #include <vector>.

[hal.canary, 2016-02-10 16:51:52]

On 2016/02/10 at 16:46:48, bungeman wrote:
>
https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument.h
> File include/core/SkDocument.h (right):
> 
>
https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument...
> include/core/SkDocument.h:134: *      std::vector<SkDocument::Attribute> info;
> If using vector here, should #include <vector>.

That was an example.

[hal.canary, 2016-02-10 18:05:42]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 18:05:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689683002/40001

[commit-bot: I haz the power, 2016-02-10 18:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 18:34:37]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-10 19:04:39]

we don't use std::vector in any other public headers, and we talked yesterday
about not over-constraining the requirements (since the api never needs the
stretchy nature of a vector). What about ptr/len ?

[hal.canary, 2016-02-10 19:08:09]

On 2016/02/10 at 19:04:39, reed wrote:
> we don't use std::vector in any other public headers, and we talked yesterday
about not over-constraining the requirements (since the api never needs the
stretchy nature of a vector). What about ptr/len ?

That's what I did.  The *caller* could use a vector, or whatever else.

[reed1, 2016-02-10 19:17:57]

Doh! -- I was reading the comment, thinking it was code. My bad.

[reed1, 2016-02-10 19:19:00]

https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument...
include/core/SkDocument.h:151: virtual void setMetadata(const
SkDocument::Attribute* /* attributes */,
skia style:

const Type named_or_not[]
int count

[hal.canary, 2016-02-10 19:48:27]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 19:48:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689683002/80001

[hal.canary, 2016-02-10 19:48:39]

https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1689683002/diff/40001/include/core/SkDocument...
include/core/SkDocument.h:151: virtual void setMetadata(const
SkDocument::Attribute* /* attributes */,
On 2016/02/10 at 19:19:00, reed1 wrote:
> skia style:
> 
> const Type named_or_not[]
> int count

done

[reed1, 2016-02-10 19:57:44]

api lgtm

[commit-bot: I haz the power, 2016-02-10 20:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 20:16:13]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-02-11 15:49:23]

lgtm, though I of course prefer size_t... I demand the koon-ut-kal-if-fee! (Ok,
maybe I'm not that determined.)

[hal.canary, 2016-02-11 15:57:52]

On 2016/02/11 at 15:49:23, bungeman wrote:
> lgtm, though I of course prefer size_t... I demand the koon-ut-kal-if-fee!
(Ok, maybe I'm not that determined.)

I really don't care between int and size_t.  leave me out of it.

[hal.canary, 2016-02-11 15:57:57]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-02-11 15:58:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689683002/80001

[commit-bot: I haz the power, 2016-02-11 16:00:14]

Description was changed from

==========
SkDocument: remove use of SkTArray (part 1/3).

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkDocument: remove use of SkTArray (part 1/3).

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7001576c7160e20c9c9db2fbe947408989027d66
==========

[commit-bot: I haz the power, 2016-02-11 16:00:15]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/7001576c7160e20c9c9db2fbe947408989027d66