gcl.py - Issue 1689633002: Finally get rid of depot_tools' breakpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 1689633002: Finally get rid of depot_tools' breakpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: fix test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 1f88025dda916ab8309550fe890107e95e953d57..a80939673c9d2008ef19e0d6cec0b31f4be1e02f 100755

--- a/gcl.py

+++ b/gcl.py

@@ -20,8 +20,6 @@ import tempfile

import time

import urllib2

-import breakpad # pylint: disable=W0611

import auth

import fix_encoding

@@ -743,12 +741,6 @@ def GetTreeStatus():

def OptionallyDoPresubmitChecks(change_info, committing, args):

if FilterFlag(args, "--no_presubmit") or FilterFlag(args, "--force"):

- breakpad.SendStack(

- breakpad.DEFAULT_URL + '/breakpad',

- 'GclHooksBypassedCommit',

- 'Issue %s/%s bypassed hook when committing (tree status was "%s")' %

- (change_info.rietveld, change_info.issue, GetTreeStatus()),

- verbose=False)

return presubmit_support.PresubmitOutput()

return DoPresubmitChecks(change_info, committing, True)

« no previous file with comments | « drover.py ('k') | gclient.py » ('j') | no next file with comments »