Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: drover.py

Issue 1689633002: Finally get rid of depot_tools' breakpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: fix test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « commit_queue.py ('k') | gcl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: drover.py
diff --git a/drover.py b/drover.py
index 87025300d680b4c154896b071e13d5e996487aa5..a73f1d347f8d12a78c5b631d1301355fdd7e23e3 100755
--- a/drover.py
+++ b/drover.py
@@ -10,7 +10,6 @@ import re
import sys
import urlparse
-import breakpad # pylint: disable=W0611
import gclient_utils
import subprocess2
@@ -377,7 +376,7 @@ def getSVNAuthInfo(folder=None):
try:
for auth_file in os.listdir(svn_simple_folder):
# Read the SVN auth file, convert it into a dictionary, and store it.
- results[auth_file] = dict(re.findall(r'K [0-9]+\n(.*)\nV [0-9]+\n(.*)\n',
+ results[auth_file] = dict(re.findall(r'K [0-9]+\n(.*)\nV [0-9]+\n(.*)\n',
open(os.path.join(svn_simple_folder, auth_file)).read()))
except Exception as _:
pass
@@ -391,7 +390,7 @@ def getCurrentSVNUsers(url):
auth_infos = getSVNAuthInfo()
results = []
for _, auth_info in auth_infos.iteritems():
- if ('svn:realmstring' in auth_info
+ if ('svn:realmstring' in auth_info
and netloc in auth_info['svn:realmstring']):
username = auth_info['username']
results.append(username)
« no previous file with comments | « commit_queue.py ('k') | gcl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698