Source/modules/speech/SpeechRecognitionEvent.h - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechRecognitionEvent.h

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/speech/SpeechRecognitionEvent.h

diff --git a/Source/modules/speech/SpeechRecognitionEvent.h b/Source/modules/speech/SpeechRecognitionEvent.h

index 583c68888c0af15b9f3686b58e9ea95206dbb32a..e716305762420dfa1e54876a860e9c08f0ef2140 100644

--- a/Source/modules/speech/SpeechRecognitionEvent.h

+++ b/Source/modules/speech/SpeechRecognitionEvent.h

@@ -52,8 +52,8 @@ public:

static PassRefPtr<SpeechRecognitionEvent> create(const AtomicString&, const SpeechRecognitionEventInit&);

virtual ~SpeechRecognitionEvent();

- static PassRefPtr<SpeechRecognitionEvent> createResult(unsigned long resultIndex, const Vector<RefPtr<SpeechRecognitionResult> >& results);

- static PassRefPtr<SpeechRecognitionEvent> createNoMatch(PassRefPtr<SpeechRecognitionResult>);

+ static PassRefPtr<SpeechRecognitionEvent> createResult(unsigned long resultIndex, const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> >& results);

+ static PassRefPtr<SpeechRecognitionEvent> createNoMatch(PassRefPtrWillBeRawPtr<SpeechRecognitionResult>);

unsigned long resultIndex() const { return m_resultIndex; }

SpeechRecognitionResultList* results() const { return m_results.get(); }

« no previous file with comments | « Source/modules/speech/SpeechRecognition.cpp ('k') | Source/modules/speech/SpeechRecognitionEvent.cpp » ('j') | public/platform/WebPrivatePtr.h » ('J')