Source/modules/speech/SpeechRecognition.h - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechRecognition.h

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/speech/SpeechRecognition.h

diff --git a/Source/modules/speech/SpeechRecognition.h b/Source/modules/speech/SpeechRecognition.h

index e279baf6a62717ef6951df4e7e96e5238425e15b..08a2790534f3d007c70bca08d2cf178b40d4cc1d 100644

--- a/Source/modules/speech/SpeechRecognition.h

+++ b/Source/modules/speech/SpeechRecognition.h

@@ -75,8 +75,8 @@ public:

void didEndSpeech();

void didEndSound();

void didEndAudio();

- void didReceiveResults(const Vector<RefPtr<SpeechRecognitionResult> >& newFinalResults, const Vector<RefPtr<SpeechRecognitionResult> >& currentInterimResults);

- void didReceiveNoMatch(PassRefPtr<SpeechRecognitionResult>);

+ void didReceiveResults(const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> >& newFinalResults, const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> >& currentInterimResults);

+ void didReceiveNoMatch(PassRefPtrWillBeRawPtr<SpeechRecognitionResult>);

void didReceiveError(PassRefPtr<SpeechRecognitionError>);

void didStart();

void didEnd();

@@ -117,7 +117,7 @@ private:

bool m_stoppedByActiveDOMObject;

bool m_started;

bool m_stopping;

- Vector<RefPtr<SpeechRecognitionResult> > m_finalResults;

+ WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> > m_finalResults;

};

} // namespace WebCore

« no previous file with comments | « Source/modules/speech/SpeechGrammar.cpp ('k') | Source/modules/speech/SpeechRecognition.cpp » ('j') | public/platform/WebPrivatePtr.h » ('J')