Source/modules/speech/SpeechGrammar.h - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechGrammar.h

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/speech/SpeechGrammar.h

diff --git a/Source/modules/speech/SpeechGrammar.h b/Source/modules/speech/SpeechGrammar.h

index 757c8f0178dfd8f4c3dd3f89a8de9e66bf0905f9..2f3cab5c16a08501ae7d3bb0ca7b3fed6ded96db 100644

--- a/Source/modules/speech/SpeechGrammar.h

+++ b/Source/modules/speech/SpeechGrammar.h

@@ -36,7 +36,7 @@ namespace WebCore {

class ExecutionContext;

-class SpeechGrammar : public RefCountedWillBeRefCountedGarbageCollected<SpeechGrammar>, public ScriptWrappable {

+class SpeechGrammar : public RefCountedWillBeGarbageCollectedFinalized<SpeechGrammar>, public ScriptWrappable {

DECLARE_GC_INFO;

public:

static PassRefPtrWillBeRawPtr<SpeechGrammar> create(); // FIXME: The spec is not clear on what the constructor should look like.

« no previous file with comments | « Source/heap/Handle.h ('k') | Source/modules/speech/SpeechGrammar.cpp » ('j') | public/platform/WebPrivatePtr.h » ('J')