Source/web/WebSpeechGrammar.cpp - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSpeechGrammar.cpp

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reuse persistent on re-assign, reduce #ifdef use. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/speech/SpeechGrammar.cpp ('k') | public/platform/WebPrivateGarbageCollectedPtr.h » ('j') | public/platform/WebPrivateGarbageCollectedPtr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebSpeechGrammar.cpp

diff --git a/Source/web/WebSpeechGrammar.cpp b/Source/web/WebSpeechGrammar.cpp

index 1b9aaa5dd4677373e44900c9ef55c36f6b1cde36..5096f50d3b410668af4ac872898f6d2b0f660cf2 100644

--- a/Source/web/WebSpeechGrammar.cpp

+++ b/Source/web/WebSpeechGrammar.cpp

@@ -41,12 +41,12 @@ void WebSpeechGrammar::assign(const WebSpeechGrammar& other)

m_private = other.m_private;

}

-WebSpeechGrammar::WebSpeechGrammar(const PassRefPtr<WebCore::SpeechGrammar>& value)

+WebSpeechGrammar::WebSpeechGrammar(const PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>& value)

: m_private(value)

{

}

-WebSpeechGrammar& WebSpeechGrammar::operator=(const WTF::PassRefPtr<WebCore::SpeechGrammar>& value)

+WebSpeechGrammar& WebSpeechGrammar::operator=(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>& value)

Mads Ager (chromium) 2014/02/17 15:18:40 I think the PassRefPtrWillBeRawPtr is in WebCore a

{

m_private = value;

return *this;