Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1689593002: Do not check security origin for default audio output device. (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not check security origin for default audio output device. The default device is always authorized, so the check is unnecessary and in some cases results in a crash. BUG=585075 Committed: https://crrev.com/4b69cb07ac783f0fc1b55608b068053871a2bde1 Cr-Commit-Position: refs/heads/master@{#374653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Guido Urdaneta
Hi, PTAL.
4 years, 10 months ago (2016-02-10 11:47:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689593002/1
4 years, 10 months ago (2016-02-10 12:33:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 13:42:51 UTC) #6
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2016-02-10 13:44:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689593002/1
4 years, 10 months ago (2016-02-10 13:44:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 13:48:56 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 13:49:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b69cb07ac783f0fc1b55608b068053871a2bde1
Cr-Commit-Position: refs/heads/master@{#374653}

Powered by Google App Engine
This is Rietveld 408576698