Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 1689573004: [interpreter] Support for ES6 super keyword. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update test262.status. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 7d1dbebe5de9d8b1835d684056e9eb7834851323..2ad6521ff29fef41ad96ab80de11e4725cdbd414 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -114,7 +114,7 @@ class BytecodeArrayBuilder final : public ZoneObject, private RegisterMover {
// Named load property.
BytecodeArrayBuilder& LoadNamedProperty(Register object,
- const Handle<String> name,
+ const Handle<Name> name,
int feedback_slot,
LanguageMode language_mode);
// Keyed load property. The key should be in the accumulator.
@@ -123,7 +123,7 @@ class BytecodeArrayBuilder final : public ZoneObject, private RegisterMover {
// Store properties. The value to be stored should be in the accumulator.
BytecodeArrayBuilder& StoreNamedProperty(Register object,
- const Handle<String> name,
+ const Handle<Name> name,
int feedback_slot,
LanguageMode language_mode);
BytecodeArrayBuilder& StoreKeyedProperty(Register object, Register key,
@@ -167,9 +167,10 @@ class BytecodeArrayBuilder final : public ZoneObject, private RegisterMover {
BytecodeArrayBuilder& Call(Register callable, Register receiver_args,
size_t receiver_arg_count, int feedback_slot);
- // Call the new operator. The |constructor| register is followed by
- // |arg_count| consecutive registers containing arguments to be
- // applied to the constructor.
+ // Call the new operator. The accumulator holds the |new_target|.
+ // The |constructor| is in a register followed by followed by
rmcilroy 2016/02/11 15:25:49 delete extra "followed by"
oth 2016/02/12 14:12:53 Done.
+ // |arg_count| consecutive arguments starting at |first_arg| for the
+ // constuctor invocation.
BytecodeArrayBuilder& New(Register constructor, Register first_arg,
size_t arg_count);

Powered by Google App Engine
This is Rietveld 408576698