[interpreter] Support for ES6 super keyword.
Adds support for ES6 super keyword and performing loads, stores, and
calls to super class members.
Implements SetHomeObject and enables ThisFunctionVariable.
BUG=v8:4280, v8:4682
LOG=N
Committed: https://crrev.com/e768bcca2494077e634dd9e1fa495b183b4344cc
Cr-Commit-Position: refs/heads/master@{#33977}
Comment incorporated and have added class for SuperPropertyArguments as discussed. PTAL. Thanks! https://codereview.chromium.org/1689573004/diff/120001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc ...
4 years, 10 months ago
(2016-02-12 16:50:34 UTC)
#7
LGTM to land when the bots are happy. https://codereview.chromium.org/1689573004/diff/140001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): https://codereview.chromium.org/1689573004/diff/140001/src/interpreter/bytecode-generator.cc#newcode561 src/interpreter/bytecode-generator.cc:561: size_t ...
4 years, 10 months ago
(2016-02-12 17:08:43 UTC)
#8
Thanks, investigating test breakage that's introduced after rebase and SuperPropertyArguments change. https://codereview.chromium.org/1689573004/diff/140001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): ...
4 years, 10 months ago
(2016-02-12 17:22:59 UTC)
#9
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/240001
4 years, 10 months ago
(2016-02-12 21:07:35 UTC)
#11
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/15280)
4 years, 10 months ago
(2016-02-12 21:46:59 UTC)
#13
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/260001
4 years, 10 months ago
(2016-02-13 07:25:42 UTC)
#15
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13713)
4 years, 10 months ago
(2016-02-13 07:44:36 UTC)
#17
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/280001
4 years, 10 months ago
(2016-02-13 09:26:13 UTC)
#20
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13716)
4 years, 10 months ago
(2016-02-13 09:30:55 UTC)
#22
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/280001
4 years, 10 months ago
(2016-02-13 12:06:55 UTC)
#24
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13718)
4 years, 10 months ago
(2016-02-13 12:14:56 UTC)
#26
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/300001
4 years, 10 months ago
(2016-02-13 12:21:05 UTC)
#29
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13720)
4 years, 10 months ago
(2016-02-13 12:25:57 UTC)
#31
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/320001
4 years, 10 months ago
(2016-02-15 07:54:40 UTC)
#33
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689573004/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689573004/320001
4 years, 10 months ago
(2016-02-15 08:17:07 UTC)
#38
4 years, 10 months ago
(2016-02-15 08:18:28 UTC)
#39
Message was sent while issue was closed.
Committed patchset #17 (id:320001)
commit-bot: I haz the power
Description was changed from ========== [interpreter] Support for ES6 super keyword. Adds support for ES6 ...
4 years, 10 months ago
(2016-02-15 08:19:14 UTC)
#40
Message was sent while issue was closed.
Description was changed from
==========
[interpreter] Support for ES6 super keyword.
Adds support for ES6 super keyword and performing loads, stores, and
calls to super class members.
Implements SetHomeObject and enables ThisFunctionVariable.
BUG=v8:4280,v8:4682
LOG=N
==========
to
==========
[interpreter] Support for ES6 super keyword.
Adds support for ES6 super keyword and performing loads, stores, and
calls to super class members.
Implements SetHomeObject and enables ThisFunctionVariable.
BUG=v8:4280,v8:4682
LOG=N
Committed: https://crrev.com/e768bcca2494077e634dd9e1fa495b183b4344cc
Cr-Commit-Position: refs/heads/master@{#33977}
==========
commit-bot: I haz the power
Patchset 17 (id:??) landed as https://crrev.com/e768bcca2494077e634dd9e1fa495b183b4344cc Cr-Commit-Position: refs/heads/master@{#33977}
4 years, 10 months ago
(2016-02-15 08:19:15 UTC)
#41
https://codereview.chromium.org/1689573004/diff/320001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): https://codereview.chromium.org/1689573004/diff/320001/src/interpreter/bytecode-generator.cc#newcode553 src/interpreter/bytecode-generator.cc:553: class BytecodeGenerator::SuperPropertyArguments final { This assumes that both, the ...
4 years, 10 months ago
(2016-02-16 16:53:09 UTC)
#43
Issue 1689573004: [interpreter] Support for ES6 super keyword.
(Closed)
Created 4 years, 10 months ago by oth
Modified 4 years, 10 months ago
Reviewers: rmcilroy, Benedikt Meurer, Michael Starzinger
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Comments: 49