third_party/WebKit/Source/core/css/cssom/LengthValue.h - Issue 1689573002: CSS Typed OM: asMatrix for TransformComponent with LengthValue types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/LengthValue.h

Issue 1689573002: CSS Typed OM: asMatrix for TransformComponent with LengthValue types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asMatrixMethod

Patch Set: Add in Translation and use exceptionState.hadException Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/translationTransformComponent.html ('k') | third_party/WebKit/Source/core/css/cssom/LengthValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/LengthValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/LengthValue.h b/third_party/WebKit/Source/core/css/cssom/LengthValue.h

index dbf2763a894796ae2f9296de4cc905255e9c7a13..91ef8eb39da32ec05394476ebda9fae8cea45bf4 100644

--- a/third_party/WebKit/Source/core/css/cssom/LengthValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/LengthValue.h

@@ -23,7 +23,10 @@ public:

LengthValue* multiply(double, ExceptionState&);

LengthValue* divide(double, ExceptionState&);

+ double computeLengthPx(ExceptionState&) const;

virtual bool containsPercent() const = 0;

+ virtual bool isRelative() const = 0;

static LengthValue* parse(const String& cssString, ExceptionState&);

static LengthValue* fromValue(double value, const String& typeStr, ExceptionState&);