Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: base/android/jni_array_unittest.cc

Issue 1689563002: android: Add ToJavaFloatArray JNI utility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added std::vector version. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_array.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_array_unittest.cc
diff --git a/base/android/jni_array_unittest.cc b/base/android/jni_array_unittest.cc
index 47f1afce5195146baf62d472c5956350a5b30a3f..09de2429e560170e6f67e4b8bd7e6c963997af7c 100644
--- a/base/android/jni_array_unittest.cc
+++ b/base/android/jni_array_unittest.cc
@@ -113,6 +113,35 @@ void CheckIntArrayConversion(JNIEnv* env,
}
}
+void CheckFloatConversion(
+ JNIEnv* env,
+ const float* float_array,
+ const size_t len,
+ const ScopedJavaLocalRef<jfloatArray>& floats) {
+ ASSERT_TRUE(floats.obj());
+
+ jsize java_array_len = env->GetArrayLength(floats.obj());
+ ASSERT_EQ(static_cast<jsize>(len), java_array_len);
+
+ jfloat value;
+ for (size_t i = 0; i < len; ++i) {
+ env->GetFloatArrayRegion(floats.obj(), i, 1, &value);
+ ASSERT_EQ(float_array[i], value);
+ }
+}
+
+TEST(JniArray, FloatConversions) {
+ const float kFloats[] = { 0.0f, 1.0f, -10.0f};
+ const size_t kLen = arraysize(kFloats);
+
+ JNIEnv* env = AttachCurrentThread();
+ CheckFloatConversion(env, kFloats, kLen,
+ ToJavaFloatArray(env, kFloats, kLen));
+
+ const std::vector<float> vec(kFloats, kFloats + kLen);
+ CheckFloatConversion(env, kFloats, kLen, ToJavaFloatArray(env, vec));
+}
+
TEST(JniArray, JavaIntArrayToIntVector) {
const int kInts[] = {0, 1, -1};
const size_t kLen = arraysize(kInts);
« no previous file with comments | « base/android/jni_array.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698