Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1689563002: android: Add ToJavaFloatArray JNI utility. (Closed)

Created:
4 years, 10 months ago by kinaba
Modified:
4 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Add ToJavaFloatArray JNI utility. This will be used from https://codereview.chromium.org/1589953005/. BUG=424866 Committed: https://crrev.com/e07c4b7742303abd7464317dca425dc7fc203d51 Cr-Commit-Position: refs/heads/master@{#374646}

Patch Set 1 #

Patch Set 2 : Added std::vector version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M base/android/jni_array.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M base/android/jni_array.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M base/android/jni_array_unittest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kinaba
+torne: PTAL. Plan is to use the function in https://codereview.chromium.org/1589953005/, but since the main CL ...
4 years, 10 months ago (2016-02-10 05:59:47 UTC) #2
Torne
Would you mind also adding a std::vector<float> version to match the others? Looks fine otherwise.
4 years, 10 months ago (2016-02-10 10:40:11 UTC) #3
kinaba
Done!
4 years, 10 months ago (2016-02-10 11:55:46 UTC) #4
Torne
lgtm
4 years, 10 months ago (2016-02-10 12:04:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689563002/20001
4 years, 10 months ago (2016-02-10 12:27:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 12:42:17 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 12:43:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e07c4b7742303abd7464317dca425dc7fc203d51
Cr-Commit-Position: refs/heads/master@{#374646}

Powered by Google App Engine
This is Rietveld 408576698