Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168953002: Cleanup: Move kChromeDevToolsScheme constant into content namespace. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, creis+watch_chromium.org, tfarina, ajwong+watch_chromium.org, browser-components-watch_chromium.org, Avi (use Gerrit), yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, aandrey+blink_chromium.org, jam, android-webview-reviews_chromium.org, pfeldman
Visibility:
Public.

Description

Cleanup: Move kChromeDevToolsScheme constant into content namespace. BUG=None TEST=None, no functional changes TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251632

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -53 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/origin_chip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/resource_request_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_url_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/savable_url_schemes.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/url_schemes.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/url_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/common/url_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
tfarina
TBRing...
6 years, 10 months ago (2014-02-16 20:43:42 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 20:43:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/168953002/20001
6 years, 10 months ago (2014-02-16 20:44:11 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-16 21:01:53 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=227753
6 years, 10 months ago (2014-02-16 21:01:53 UTC) #5
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 21:04:52 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 21:04:52 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 21:04:53 UTC) #8
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 21:04:53 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 21:04:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/168953002/20001
6 years, 10 months ago (2014-02-16 21:05:09 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-16 21:05:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-16 21:05:41 UTC) #13
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-16 21:27:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/168953002/340001
6 years, 10 months ago (2014-02-16 21:27:39 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 00:32:51 UTC) #16
Message was sent while issue was closed. 
Change committed as 251632

Powered by Google App Engine
This is Rietveld 408576698