Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issue 1689483002: MacViews: Implement NativeWidgetMac::SchedulePaintInRect. (Closed)

Created:
4 years, 10 months ago by karandeepb
Modified:
4 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Implement NativeWidgetMac::SchedulePaintInRect. This CL implements NativeWidgetMac::SchedulePaintInRect which forwards the passed dirty/damaged rectangle to the BridgedContentView after performing appropriate coordinate conversions. This can then be used by -[NSView drawRect:] to optimize drawing. BUG=454698 Committed: https://crrev.com/a9514dd91a8905b9332527b6e61432e4df66a081 Cr-Commit-Position: refs/heads/master@{#374601}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -3 lines) Patch
M ui/views/widget/native_widget_mac.mm View 1 1 chunk +9 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 3 chunks +111 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
karandeepb
PTAL Trent. Thanks.
4 years, 10 months ago (2016-02-10 00:37:07 UTC) #3
tapted
lgtm
4 years, 10 months ago (2016-02-10 00:48:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689483002/20001
4 years, 10 months ago (2016-02-10 04:16:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 04:22:08 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 04:23:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9514dd91a8905b9332527b6e61432e4df66a081
Cr-Commit-Position: refs/heads/master@{#374601}

Powered by Google App Engine
This is Rietveld 408576698